You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Pradeep Agrawal <pr...@gmail.com> on 2019/06/20 14:33:36 UTC

Review Request 70908: RANGER-2479: Change test connection preferred SQL statement for Oracle DB Flavor

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70908/
-----------------------------------------------------------

Review request for ranger, Ankita Sinha, bhavik patel, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Nitin Galave, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.


Bugs: RANGER-2479
    https://issues.apache.org/jira/browse/RANGER-2479


Repository: ranger


Description
-------

Currently test connection preferred SQL statement is set to "Select 1" for all the DB flavors which may not work for Oracle as it should be "Select 1 from dual;"

Proposed solution shall replace the value of "ranger.jpa.jdbc.preferredtestquery" property in ranger-admin-default-site.xml file during the ranger installation.


Diffs
-----

  security-admin/scripts/setup.sh 4916828ce 


Diff: https://reviews.apache.org/r/70908/diff/1/


Testing
-------

Tested ranger installation and can see ranger.jpa.jdbc.preferredtestquery values updated to "Select 1 from dual;" for oracle db flavor.


Thanks,

Pradeep Agrawal


Re: Review Request 70908: RANGER-2479: Change test connection preferred SQL statement for Oracle DB Flavor

Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70908/#review216091
-----------------------------------------------------------


Ship it!




Ship It!

- Velmurugan Periasamy


On June 20, 2019, 2:33 p.m., Pradeep Agrawal wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70908/
> -----------------------------------------------------------
> 
> (Updated June 20, 2019, 2:33 p.m.)
> 
> 
> Review request for ranger, Ankita Sinha, bhavik patel, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Nitin Galave, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2479
>     https://issues.apache.org/jira/browse/RANGER-2479
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Currently test connection preferred SQL statement is set to "Select 1" for all the DB flavors which may not work for Oracle as it should be "Select 1 from dual;"
> 
> Proposed solution shall replace the value of "ranger.jpa.jdbc.preferredtestquery" property in ranger-admin-default-site.xml file during the ranger installation.
> 
> 
> Diffs
> -----
> 
>   security-admin/scripts/setup.sh 4916828ce 
> 
> 
> Diff: https://reviews.apache.org/r/70908/diff/2/
> 
> 
> Testing
> -------
> 
> Tested ranger installation and can see ranger.jpa.jdbc.preferredtestquery values updated to "Select 1 from dual;" for oracle db flavor.
> 
> 
> Thanks,
> 
> Pradeep Agrawal
> 
>