You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/01/21 16:23:15 UTC

[GitHub] [maven-build-cache-extension] andrey-petrenko-db commented on a change in pull request #4: [MBUILDCACHE-15] maven.build.cache.enabled parameter is broken - fix

andrey-petrenko-db commented on a change in pull request #4:
URL: https://github.com/apache/maven-build-cache-extension/pull/4#discussion_r789800751



##########
File path: src/main/java/org/apache/maven/buildcache/RemoteCacheRepositoryProvider.java
##########
@@ -42,8 +43,12 @@
     public RemoteCacheRepositoryProvider( CacheConfig config, PlexusContainer container )
             throws ComponentLookupException
     {
-        config.initialize();
-        String hint = config.getTransport();
+        String hint = "noop";
+        if ( config.initialize() == CacheState.INITIALIZED )

Review comment:
       maybe implement DisabledCacheConfig or NoopCacheConfig to remove such checks across code?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org