You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by vladimir-kotikov <gi...@git.apache.org> on 2016/11/01 10:57:12 UTC
[GitHub] cordova-lib pull request #506: CB-12088 Fix misleading warning when adding p...
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/506
CB-12088 Fix misleading warning when adding platform without Api.js
### Platforms affected
All
### What does this PR do?
Changes the logic that emits warning when require `Api.js` for platform fails to skip the warning when platform does not expose its Api
### What testing has been done on this change?
Manual testing
### Checklist
- [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vladimir-kotikov/cordova-lib CB-12088
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-lib/pull/506.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #506
----
commit ac34793ef188e5eccb99b0227902cadaddee01e6
Author: Vladimir Kotikov <v-...@microsoft.com>
Date: 2016-11-01T10:48:51Z
CB-12088 Fix misleading warning when adding platform without Api.js
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-lib pull request #506: CB-12088 Fix misleading warning when adding p...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/506
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org