You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "xuzifu666 (via GitHub)" <gi...@apache.org> on 2025/03/09 13:50:01 UTC
[PR] [CALCITE-6879] Dialect support APPROX_DISTINCT_COUNT for more dialects [calcite]
xuzifu666 opened a new pull request, #4234:
URL: https://github.com/apache/calcite/pull/4234
As description in JIRA: https://issues.apache.org/jira/browse/CALCITE-6879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6879] Dialect support APPROX_DISTINCT_COUNT for more dialects [calcite]
Posted by "xuzifu666 (via GitHub)" <gi...@apache.org>.
xuzifu666 commented on code in PR #4234:
URL: https://github.com/apache/calcite/pull/4234#discussion_r1986515620
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -8099,14 +8099,24 @@ private void checkLiteral2(String expression, String expected) {
+ "FROM \"foodmart\".\"product\"";
final String expectedStarRocksSql = "SELECT APPROX_COUNT_DISTINCT(`product_id`)\n"
+ "FROM `foodmart`.`product`";
+ final String expectedMssql = "SELECT APPROX_COUNT_DISTINCT([product_id])\n"
+ + "FROM [foodmart].[product]";
+ final String expectedPhoenix = "SELECT APPROX_COUNT_DISTINCT(\"product_id\")\n"
Review Comment:
Thanks for your reminder, had addressed @mihaibudiu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6879] Dialect support APPROX_DISTINCT_COUNT for more dialects [calcite]
Posted by "mihaibudiu (via GitHub)" <gi...@apache.org>.
mihaibudiu commented on code in PR #4234:
URL: https://github.com/apache/calcite/pull/4234#discussion_r1986367231
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -8099,14 +8099,24 @@ private void checkLiteral2(String expression, String expected) {
+ "FROM \"foodmart\".\"product\"";
final String expectedStarRocksSql = "SELECT APPROX_COUNT_DISTINCT(`product_id`)\n"
+ "FROM `foodmart`.`product`";
+ final String expectedMssql = "SELECT APPROX_COUNT_DISTINCT([product_id])\n"
+ + "FROM [foodmart].[product]";
+ final String expectedPhoenix = "SELECT APPROX_COUNT_DISTINCT(\"product_id\")\n"
Review Comment:
is this exactly the same as ApproxQuota above?
Is there a benefit having two identical strings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6879] Dialect support APPROX_DISTINCT_COUNT for more dialects [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4234:
URL: https://github.com/apache/calcite/pull/4234#issuecomment-2710445910
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4234) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4234&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4234&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4234&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4234&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4234&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4234)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6879] Dialect support APPROX_DISTINCT_COUNT for more dialects [calcite]
Posted by "zabetak (via GitHub)" <gi...@apache.org>.
zabetak closed pull request #4234: [CALCITE-6879] Dialect support APPROX_DISTINCT_COUNT for more dialects
URL: https://github.com/apache/calcite/pull/4234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6879] Dialect support APPROX_DISTINCT_COUNT for more dialects [calcite]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #4234:
URL: https://github.com/apache/calcite/pull/4234#issuecomment-2708879843
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4234) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4234&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=4234&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=4234&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [100.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4234&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=4234&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=4234)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org