You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/07/02 20:34:42 UTC

[GitHub] betodealmeida commented on issue #5322: Deconstuct utils in viz.py

betodealmeida commented on issue #5322: Deconstuct utils in viz.py
URL: https://github.com/apache/incubator-superset/pull/5322#issuecomment-401926178
 
 
   I agree with @mistercrunch. While I prefer importing object explicitly (like in your PR), the decision for one style or the other is mostly subjective, and I because of that I think it might be better to leave the code as it is.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org