You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@solr.apache.org by mk...@apache.org on 2024/02/25 12:36:39 UTC

(solr) branch main updated: SOLR-17058: fix TestDistribIDF.testDisableDistribStats failure on LRUStatsCache (#2299)

This is an automated email from the ASF dual-hosted git repository.

mkhl pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/solr.git


The following commit(s) were added to refs/heads/main by this push:
     new b1875958327 SOLR-17058: fix TestDistribIDF.testDisableDistribStats failure on LRUStatsCache (#2299)
b1875958327 is described below

commit b1875958327fee9d3d198d639a02ad36b44934e8
Author: Mikhail Khludnev <mk...@users.noreply.github.com>
AuthorDate: Sun Feb 25 15:36:33 2024 +0300

    SOLR-17058: fix TestDistribIDF.testDisableDistribStats failure on LRUStatsCache (#2299)
    
     - use another field to penetrate LRUStatsCache
---
 .../src/test/org/apache/solr/search/stats/TestDistribIDF.java | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/solr/core/src/test/org/apache/solr/search/stats/TestDistribIDF.java b/solr/core/src/test/org/apache/solr/search/stats/TestDistribIDF.java
index e43c1dd7344..e753d5c8289 100644
--- a/solr/core/src/test/org/apache/solr/search/stats/TestDistribIDF.java
+++ b/solr/core/src/test/org/apache/solr/search/stats/TestDistribIDF.java
@@ -31,7 +31,6 @@ import org.apache.solr.cloud.SolrCloudTestCase;
 import org.apache.solr.common.SolrInputDocument;
 import org.apache.solr.common.cloud.CompositeIdRouter;
 import org.apache.solr.common.cloud.ImplicitDocRouter;
-import org.apache.solr.common.params.CommonParams;
 import org.apache.solr.common.params.ShardParams;
 import org.apache.solr.common.util.NamedList;
 import org.apache.solr.embedded.JettySolrRunner;
@@ -300,8 +299,8 @@ public class TestDistribIDF extends SolrTestCaseJ4 {
     assertNotNull("stats cache hit", track.get("PARSE_QUERY"));
 
     // distributed stats explicitly disabled
-    query.set(CommonParams.DISTRIB_STATS_CACHE, "false");
-    query.set(CommonParams.Q, "{!terms f=id}1,2");
+    query.set("distrib.statsCache", "false");
+    query.set("q", "{!terms f=id}1,2");
     rsp = client.query(COLLECTION, query);
     track = (NamedList<Object>) rsp.getDebugMap().get("track");
     assertNotNull(track);
@@ -309,11 +308,11 @@ public class TestDistribIDF extends SolrTestCaseJ4 {
     assertNotNull("just search", track.get("EXECUTE_QUERY"));
 
     // distributed stats explicitly enabled
-    query.set(CommonParams.DISTRIB_STATS_CACHE, "true");
-    query.set(CommonParams.Q, "cat:electronics");
+    query.set("distrib.statsCache", "true");
+    query.set("q", "name:ipad"); // trick around LRUStatsCache
     rsp = client.query(COLLECTION, query);
     track = (NamedList<Object>) rsp.getDebugMap().get("track");
     assertNotNull(track);
-    assertNotNull("stats cache hit", track.get("PARSE_QUERY"));
+    assertNotNull("stats cache hit:" + track, track.get("PARSE_QUERY"));
   }
 }