You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "shenyu0127 (via GitHub)" <gi...@apache.org> on 2023/06/06 19:18:56 UTC
[GitHub] [pinot] shenyu0127 opened a new pull request, #10859: Refactor single column distinct executors.
shenyu0127 opened a new pull request, #10859:
URL: https://github.com/apache/pinot/pull/10859
This PR moves the common logic `process` into the base single column distinct executor class.
Tested in unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #10859: Refactor single column distinct executors.
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #10859:
URL: https://github.com/apache/pinot/pull/10859#issuecomment-1579657424
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10859?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#10859](https://app.codecov.io/gh/apache/pinot/pull/10859?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1e04f87) into [master](https://app.codecov.io/gh/apache/pinot/commit/3b2e31cfad6d327ca41021e091812f0f7e17e453?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3b2e31c) will **decrease** coverage by `10.41%`.
> The diff coverage is `4.16%`.
```diff
@@ Coverage Diff @@
## master #10859 +/- ##
=============================================
- Coverage 34.52% 24.12% -10.41%
+ Complexity 462 49 -413
=============================================
Files 2174 2158 -16
Lines 116848 116294 -554
Branches 17692 17602 -90
=============================================
- Hits 40339 28051 -12288
- Misses 72991 85280 +12289
+ Partials 3518 2963 -555
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `24.12% <4.16%> (+0.14%)` | :arrow_up: |
| integration2 | `?` | |
| unittests2 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/pinot/pull/10859?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...BaseRawBigDecimalSingleColumnDistinctExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10859?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvQmFzZVJhd0JpZ0RlY2ltYWxTaW5nbGVDb2x1bW5EaXN0aW5jdEV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../raw/BaseRawBytesSingleColumnDistinctExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10859?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvQmFzZVJhd0J5dGVzU2luZ2xlQ29sdW1uRGlzdGluY3RFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../raw/BaseRawFloatSingleColumnDistinctExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10859?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvQmFzZVJhd0Zsb2F0U2luZ2xlQ29sdW1uRGlzdGluY3RFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (-77.78%)` | :arrow_down: |
| [...ct/raw/BaseRawIntSingleColumnDistinctExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10859?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvQmFzZVJhd0ludFNpbmdsZUNvbHVtbkRpc3RpbmN0RXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (-88.89%)` | :arrow_down: |
| [...t/raw/BaseRawLongSingleColumnDistinctExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10859?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvQmFzZVJhd0xvbmdTaW5nbGVDb2x1bW5EaXN0aW5jdEV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...raw/BaseRawStringSingleColumnDistinctExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10859?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvQmFzZVJhd1N0cmluZ1NpbmdsZUNvbHVtbkRpc3RpbmN0RXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...RawBigDecimalSingleColumnDistinctOnlyExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10859?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvUmF3QmlnRGVjaW1hbFNpbmdsZUNvbHVtbkRpc3RpbmN0T25seUV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...BigDecimalSingleColumnDistinctOrderByExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10859?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvUmF3QmlnRGVjaW1hbFNpbmdsZUNvbHVtbkRpc3RpbmN0T3JkZXJCeUV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../raw/RawBytesSingleColumnDistinctOnlyExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10859?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvUmF3Qnl0ZXNTaW5nbGVDb2x1bW5EaXN0aW5jdE9ubHlFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...w/RawBytesSingleColumnDistinctOrderByExecutor.java](https://app.codecov.io/gh/apache/pinot/pull/10859?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9kaXN0aW5jdC9yYXcvUmF3Qnl0ZXNTaW5nbGVDb2x1bW5EaXN0aW5jdE9yZGVyQnlFeGVjdXRvci5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [11 more](https://app.codecov.io/gh/apache/pinot/pull/10859?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [513 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/10859/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang merged pull request #10859: Refactor single column distinct executors.
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #10859:
URL: https://github.com/apache/pinot/pull/10859
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org