You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@opennlp.apache.org by Jörn Kottmann <ko...@gmail.com> on 2013/10/23 09:14:54 UTC

Re: svn commit: r1534864 - /opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/entitylinker/GeoHashBinScorer.java

Probably because the build server is using a Java 5.

Jörn

On 10/23/2013 02:00 AM, markg@apache.org wrote:
> Author: markg
> Date: Wed Oct 23 00:00:57 2013
> New Revision: 1534864
>
> URL: http://svn.apache.org/r1534864
> Log:
> OPENNLP-608
> Deleted GeoHashBinScorer so the build will become stable. Hudson claiming methods missing from core java objects (TreeSet)....not sure why
>
> Removed:
>      opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/entitylinker/GeoHashBinScorer.java
>


Re: svn commit: r1534864 - /opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/entitylinker/GeoHashBinScorer.java

Posted by Mark G <gi...@gmail.com>.
I did some research.... never configured jenkins/hudson before.... but it
looks like if we change the reactor POM from
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<source>1.5</source>
<target>1.5</target>
<compilerArgument>-Xlint</compilerArgument>
</configuration>
</plugin>
to
<source>1.7</source>
<target>1.7</target>
and make sure 1.7 is actually on the server, JAVA_HOME is set and java 1.7
is on the PATH, it should be fairly straight forward
If you have any experience/advice let me know if this makes sense or not.

thanks
MG


On Fri, Oct 25, 2013 at 12:27 PM, Mark G <gi...@gmail.com> wrote:

> OK, is there anything we need to do to the CI server? If so, I will need
> access to it of course.
> Thanks
> MG
>
>
> On Fri, Oct 25, 2013 at 11:39 AM, Jörn Kottmann <ko...@gmail.com>wrote:
>
>> +1 to do it for the 1.6.0 release. Lets reach consensus to which version
>> we switch and then it can be done.
>>
>> Its not a big deal, we need to update the pom.xml files and maybe some
>> requirement
>> section in our documentation.
>>
>> It would be nice if you could take this over Mark.
>>
>> Jörn
>>
>>
>> On 10/25/2013 12:09 PM, Mark G wrote:
>>
>>> When is the best time to do it? Let me know how I can help.
>>> MG
>>>
>>>
>>> On Wed, Oct 23, 2013 at 8:02 PM, James Kosin <ja...@gmail.com>
>>> wrote:
>>>
>>>  +1, the good news is we don't need any changes for 7 support.  It works
>>>> as
>>>> is now.
>>>> I use 7 currently for development.
>>>>
>>>> - James Kosin
>>>>
>>>>
>>>> On 10/23/2013 2:35 PM, William Colen wrote:
>>>>
>>>>  +1 move do 6 or 7 for the next major release. We can ask what our users
>>>>> think of it.
>>>>>
>>>>> Em quarta-feira, 23 de outubro de 2013, Ioan Barbulescu escreveu:
>>>>>
>>>>>   Hi guys
>>>>>
>>>>>> I would vote for java 7, as well.
>>>>>>
>>>>>> Thank you.
>>>>>>
>>>>>> BR,
>>>>>> Ioan
>>>>>>
>>>>>>
>>>>>> On Wed, Oct 23, 2013 at 6:24 PM, Mark G <giaconiamark@gmail.com<**
>>>>>>
>>>>>> javascript:;>>
>>>>>> wrote:
>>>>>>
>>>>>>   agree, straight to 7 makes sense to me... "try with resources",
>>>>>> better
>>>>>>
>>>>>>> collections support, switch on strings etc.... all new in 7
>>>>>>>
>>>>>>>
>>>>>>> On Wed, Oct 23, 2013 at 8:36 AM, Jörn Kottmann <kottmann@gmail.com
>>>>>>> <**
>>>>>>> javascript:;>>
>>>>>>>
>>>>>>>  wrote:
>>>>>>
>>>>>>  On 10/23/2013 01:21 PM, Mark G wrote:
>>>>>>>
>>>>>>>>   When will we move to 6?
>>>>>>>>
>>>>>>>>>   I don't have any strong opinions about moving forward. Some say
>>>>>>>>> it
>>>>>>>>>
>>>>>>>> might
>>>>>>> be better
>>>>>>>
>>>>>>>> to move directly to Java 7 or even wait for Java 8.
>>>>>>>>
>>>>>>>> There are not that many interesting new features in Java 6, thats
>>>>>>>> why I
>>>>>>>> believe it might
>>>>>>>> be worth to make a bigger step to avoid one or two versions.
>>>>>>>>
>>>>>>>> Any opinions? Do we still have a Java 5 user here?
>>>>>>>>
>>>>>>>> Jörn
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>
>

Re: svn commit: r1534864 - /opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/entitylinker/GeoHashBinScorer.java

Posted by Mark G <gi...@gmail.com>.
OK, is there anything we need to do to the CI server? If so, I will need
access to it of course.
Thanks
MG


On Fri, Oct 25, 2013 at 11:39 AM, Jörn Kottmann <ko...@gmail.com> wrote:

> +1 to do it for the 1.6.0 release. Lets reach consensus to which version
> we switch and then it can be done.
>
> Its not a big deal, we need to update the pom.xml files and maybe some
> requirement
> section in our documentation.
>
> It would be nice if you could take this over Mark.
>
> Jörn
>
>
> On 10/25/2013 12:09 PM, Mark G wrote:
>
>> When is the best time to do it? Let me know how I can help.
>> MG
>>
>>
>> On Wed, Oct 23, 2013 at 8:02 PM, James Kosin <ja...@gmail.com>
>> wrote:
>>
>>  +1, the good news is we don't need any changes for 7 support.  It works
>>> as
>>> is now.
>>> I use 7 currently for development.
>>>
>>> - James Kosin
>>>
>>>
>>> On 10/23/2013 2:35 PM, William Colen wrote:
>>>
>>>  +1 move do 6 or 7 for the next major release. We can ask what our users
>>>> think of it.
>>>>
>>>> Em quarta-feira, 23 de outubro de 2013, Ioan Barbulescu escreveu:
>>>>
>>>>   Hi guys
>>>>
>>>>> I would vote for java 7, as well.
>>>>>
>>>>> Thank you.
>>>>>
>>>>> BR,
>>>>> Ioan
>>>>>
>>>>>
>>>>> On Wed, Oct 23, 2013 at 6:24 PM, Mark G <giaconiamark@gmail.com<**
>>>>>
>>>>> javascript:;>>
>>>>> wrote:
>>>>>
>>>>>   agree, straight to 7 makes sense to me... "try with resources",
>>>>> better
>>>>>
>>>>>> collections support, switch on strings etc.... all new in 7
>>>>>>
>>>>>>
>>>>>> On Wed, Oct 23, 2013 at 8:36 AM, Jörn Kottmann <kottmann@gmail.com<**
>>>>>> javascript:;>>
>>>>>>
>>>>>>  wrote:
>>>>>
>>>>>  On 10/23/2013 01:21 PM, Mark G wrote:
>>>>>>
>>>>>>>   When will we move to 6?
>>>>>>>
>>>>>>>>   I don't have any strong opinions about moving forward. Some say it
>>>>>>>>
>>>>>>> might
>>>>>> be better
>>>>>>
>>>>>>> to move directly to Java 7 or even wait for Java 8.
>>>>>>>
>>>>>>> There are not that many interesting new features in Java 6, thats
>>>>>>> why I
>>>>>>> believe it might
>>>>>>> be worth to make a bigger step to avoid one or two versions.
>>>>>>>
>>>>>>> Any opinions? Do we still have a Java 5 user here?
>>>>>>>
>>>>>>> Jörn
>>>>>>>
>>>>>>>
>>>>>>>
>

Re: svn commit: r1534864 - /opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/entitylinker/GeoHashBinScorer.java

Posted by Jörn Kottmann <ko...@gmail.com>.
+1 to do it for the 1.6.0 release. Lets reach consensus to which version
we switch and then it can be done.

Its not a big deal, we need to update the pom.xml files and maybe some 
requirement
section in our documentation.

It would be nice if you could take this over Mark.

Jörn

On 10/25/2013 12:09 PM, Mark G wrote:
> When is the best time to do it? Let me know how I can help.
> MG
>
>
> On Wed, Oct 23, 2013 at 8:02 PM, James Kosin <ja...@gmail.com> wrote:
>
>> +1, the good news is we don't need any changes for 7 support.  It works as
>> is now.
>> I use 7 currently for development.
>>
>> - James Kosin
>>
>>
>> On 10/23/2013 2:35 PM, William Colen wrote:
>>
>>> +1 move do 6 or 7 for the next major release. We can ask what our users
>>> think of it.
>>>
>>> Em quarta-feira, 23 de outubro de 2013, Ioan Barbulescu escreveu:
>>>
>>>   Hi guys
>>>> I would vote for java 7, as well.
>>>>
>>>> Thank you.
>>>>
>>>> BR,
>>>> Ioan
>>>>
>>>>
>>>> On Wed, Oct 23, 2013 at 6:24 PM, Mark G <giaconiamark@gmail.com<**
>>>> javascript:;>>
>>>> wrote:
>>>>
>>>>   agree, straight to 7 makes sense to me... "try with resources", better
>>>>> collections support, switch on strings etc.... all new in 7
>>>>>
>>>>>
>>>>> On Wed, Oct 23, 2013 at 8:36 AM, Jörn Kottmann <kottmann@gmail.com<**
>>>>> javascript:;>>
>>>>>
>>>> wrote:
>>>>
>>>>> On 10/23/2013 01:21 PM, Mark G wrote:
>>>>>>   When will we move to 6?
>>>>>>>   I don't have any strong opinions about moving forward. Some say it
>>>>> might
>>>>> be better
>>>>>> to move directly to Java 7 or even wait for Java 8.
>>>>>>
>>>>>> There are not that many interesting new features in Java 6, thats why I
>>>>>> believe it might
>>>>>> be worth to make a bigger step to avoid one or two versions.
>>>>>>
>>>>>> Any opinions? Do we still have a Java 5 user here?
>>>>>>
>>>>>> Jörn
>>>>>>
>>>>>>


Re: svn commit: r1534864 - /opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/entitylinker/GeoHashBinScorer.java

Posted by Mark G <gi...@gmail.com>.
When is the best time to do it? Let me know how I can help.
MG


On Wed, Oct 23, 2013 at 8:02 PM, James Kosin <ja...@gmail.com> wrote:

> +1, the good news is we don't need any changes for 7 support.  It works as
> is now.
> I use 7 currently for development.
>
> - James Kosin
>
>
> On 10/23/2013 2:35 PM, William Colen wrote:
>
>> +1 move do 6 or 7 for the next major release. We can ask what our users
>> think of it.
>>
>> Em quarta-feira, 23 de outubro de 2013, Ioan Barbulescu escreveu:
>>
>>  Hi guys
>>>
>>> I would vote for java 7, as well.
>>>
>>> Thank you.
>>>
>>> BR,
>>> Ioan
>>>
>>>
>>> On Wed, Oct 23, 2013 at 6:24 PM, Mark G <giaconiamark@gmail.com<**
>>> javascript:;>>
>>> wrote:
>>>
>>>  agree, straight to 7 makes sense to me... "try with resources", better
>>>> collections support, switch on strings etc.... all new in 7
>>>>
>>>>
>>>> On Wed, Oct 23, 2013 at 8:36 AM, Jörn Kottmann <kottmann@gmail.com<**
>>>> javascript:;>>
>>>>
>>> wrote:
>>>
>>>> On 10/23/2013 01:21 PM, Mark G wrote:
>>>>>
>>>>>  When will we move to 6?
>>>>>>
>>>>>>  I don't have any strong opinions about moving forward. Some say it
>>>>>
>>>> might
>>>
>>>> be better
>>>>> to move directly to Java 7 or even wait for Java 8.
>>>>>
>>>>> There are not that many interesting new features in Java 6, thats why I
>>>>> believe it might
>>>>> be worth to make a bigger step to avoid one or two versions.
>>>>>
>>>>> Any opinions? Do we still have a Java 5 user here?
>>>>>
>>>>> Jörn
>>>>>
>>>>>
>>
>

Re: svn commit: r1534864 - /opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/entitylinker/GeoHashBinScorer.java

Posted by James Kosin <ja...@gmail.com>.
+1, the good news is we don't need any changes for 7 support.  It works 
as is now.
I use 7 currently for development.

- James Kosin

On 10/23/2013 2:35 PM, William Colen wrote:
> +1 move do 6 or 7 for the next major release. We can ask what our users
> think of it.
>
> Em quarta-feira, 23 de outubro de 2013, Ioan Barbulescu escreveu:
>
>> Hi guys
>>
>> I would vote for java 7, as well.
>>
>> Thank you.
>>
>> BR,
>> Ioan
>>
>>
>> On Wed, Oct 23, 2013 at 6:24 PM, Mark G <giaconiamark@gmail.com<javascript:;>>
>> wrote:
>>
>>> agree, straight to 7 makes sense to me... "try with resources", better
>>> collections support, switch on strings etc.... all new in 7
>>>
>>>
>>> On Wed, Oct 23, 2013 at 8:36 AM, Jörn Kottmann <kottmann@gmail.com<javascript:;>>
>> wrote:
>>>> On 10/23/2013 01:21 PM, Mark G wrote:
>>>>
>>>>> When will we move to 6?
>>>>>
>>>> I don't have any strong opinions about moving forward. Some say it
>> might
>>>> be better
>>>> to move directly to Java 7 or even wait for Java 8.
>>>>
>>>> There are not that many interesting new features in Java 6, thats why I
>>>> believe it might
>>>> be worth to make a bigger step to avoid one or two versions.
>>>>
>>>> Any opinions? Do we still have a Java 5 user here?
>>>>
>>>> Jörn
>>>>
>


Re: svn commit: r1534864 - /opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/entitylinker/GeoHashBinScorer.java

Posted by William Colen <wi...@gmail.com>.
+1 move do 6 or 7 for the next major release. We can ask what our users
think of it.

Em quarta-feira, 23 de outubro de 2013, Ioan Barbulescu escreveu:

> Hi guys
>
> I would vote for java 7, as well.
>
> Thank you.
>
> BR,
> Ioan
>
>
> On Wed, Oct 23, 2013 at 6:24 PM, Mark G <giaconiamark@gmail.com<javascript:;>>
> wrote:
>
> > agree, straight to 7 makes sense to me... "try with resources", better
> > collections support, switch on strings etc.... all new in 7
> >
> >
> > On Wed, Oct 23, 2013 at 8:36 AM, Jörn Kottmann <kottmann@gmail.com<javascript:;>>
> wrote:
> >
> > > On 10/23/2013 01:21 PM, Mark G wrote:
> > >
> > >> When will we move to 6?
> > >>
> > >
> > > I don't have any strong opinions about moving forward. Some say it
> might
> > > be better
> > > to move directly to Java 7 or even wait for Java 8.
> > >
> > > There are not that many interesting new features in Java 6, thats why I
> > > believe it might
> > > be worth to make a bigger step to avoid one or two versions.
> > >
> > > Any opinions? Do we still have a Java 5 user here?
> > >
> > > Jörn
> > >
> >
>


-- 
William Colen

Re: svn commit: r1534864 - /opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/entitylinker/GeoHashBinScorer.java

Posted by Ioan Barbulescu <ib...@gmail.com>.
Hi guys

I would vote for java 7, as well.

Thank you.

BR,
Ioan


On Wed, Oct 23, 2013 at 6:24 PM, Mark G <gi...@gmail.com> wrote:

> agree, straight to 7 makes sense to me... "try with resources", better
> collections support, switch on strings etc.... all new in 7
>
>
> On Wed, Oct 23, 2013 at 8:36 AM, Jörn Kottmann <ko...@gmail.com> wrote:
>
> > On 10/23/2013 01:21 PM, Mark G wrote:
> >
> >> When will we move to 6?
> >>
> >
> > I don't have any strong opinions about moving forward. Some say it might
> > be better
> > to move directly to Java 7 or even wait for Java 8.
> >
> > There are not that many interesting new features in Java 6, thats why I
> > believe it might
> > be worth to make a bigger step to avoid one or two versions.
> >
> > Any opinions? Do we still have a Java 5 user here?
> >
> > Jörn
> >
>

Re: svn commit: r1534864 - /opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/entitylinker/GeoHashBinScorer.java

Posted by Mark G <gi...@gmail.com>.
agree, straight to 7 makes sense to me... "try with resources", better
collections support, switch on strings etc.... all new in 7


On Wed, Oct 23, 2013 at 8:36 AM, Jörn Kottmann <ko...@gmail.com> wrote:

> On 10/23/2013 01:21 PM, Mark G wrote:
>
>> When will we move to 6?
>>
>
> I don't have any strong opinions about moving forward. Some say it might
> be better
> to move directly to Java 7 or even wait for Java 8.
>
> There are not that many interesting new features in Java 6, thats why I
> believe it might
> be worth to make a bigger step to avoid one or two versions.
>
> Any opinions? Do we still have a Java 5 user here?
>
> Jörn
>

Re: svn commit: r1534864 - /opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/entitylinker/GeoHashBinScorer.java

Posted by Jörn Kottmann <ko...@gmail.com>.
On 10/23/2013 01:21 PM, Mark G wrote:
> When will we move to 6?

I don't have any strong opinions about moving forward. Some say it might 
be better
to move directly to Java 7 or even wait for Java 8.

There are not that many interesting new features in Java 6, thats why I 
believe it might
be worth to make a bigger step to avoid one or two versions.

Any opinions? Do we still have a Java 5 user here?

Jörn

Re: svn commit: r1534864 - /opennlp/trunk/opennlp-tools/src/main/java/opennlp/tools/entitylinker/GeoHashBinScorer.java

Posted by Mark G <gi...@gmail.com>.
I investigated and you are right, even though I am building with Java 5
locally, the treeset.higher(),and treeset.subset() are not there in Java
5....
When will we move to 6?
MG


On Wed, Oct 23, 2013 at 3:14 AM, Jörn Kottmann <ko...@gmail.com> wrote:

> Probably because the build server is using a Java 5.
>
> Jörn
>
>
> On 10/23/2013 02:00 AM, markg@apache.org wrote:
>
>> Author: markg
>> Date: Wed Oct 23 00:00:57 2013
>> New Revision: 1534864
>>
>> URL: http://svn.apache.org/r1534864
>> Log:
>> OPENNLP-608
>> Deleted GeoHashBinScorer so the build will become stable. Hudson claiming
>> methods missing from core java objects (TreeSet)....not sure why
>>
>> Removed:
>>      opennlp/trunk/opennlp-tools/**src/main/java/opennlp/tools/**
>> entitylinker/GeoHashBinScorer.**java
>>
>>
>