You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/13 07:08:09 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request, #38236: [MINOR][DOCS][CONNECT] Fix docs to run Spark Connect locally built
HyukjinKwon opened a new pull request, #38236:
URL: https://github.com/apache/spark/pull/38236
### What changes were proposed in this pull request?
This PR adds some more command examples to run Spark Connect that you built locally.
### Why are the changes needed?
To guide developers to run Spark Connect they built locally.
### Does this PR introduce _any_ user-facing change?
No, dev-only and doc-only.
### How was this patch tested?
N/A. The commands are tested manually in locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38236: [MINOR][DOCS][CONNECT] Fix docs to run Spark Connect locally built
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38236:
URL: https://github.com/apache/spark/pull/38236#issuecomment-1277129615
cc @zhengruifeng @amaliujia FYI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #38236: [MINOR][DOCS][CONNECT] Fix docs to run Spark Connect locally built
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #38236:
URL: https://github.com/apache/spark/pull/38236#issuecomment-1277133882
maybe we can also modify the last test cmd:
`./run-tests --testnames 'pyspark.sql.tests.test_connect_basic'`
to
`./python/run-tests --testnames 'pyspark.sql.tests.test_connect_basic'`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] grundprinzip commented on a diff in pull request #38236: [MINOR][DOCS][CONNECT] Fix docs to run Spark Connect locally built
Posted by GitBox <gi...@apache.org>.
grundprinzip commented on code in PR #38236:
URL: https://github.com/apache/spark/pull/38236#discussion_r994253417
##########
python/pyspark/sql/connect/README.md:
##########
@@ -9,22 +9,34 @@ of Spark. To enable it, you only need to activate the driver plugin for Spark Co
## Build
-1. Build Spark as usual per the documentation.
-
-2. Build and package the Spark Connect package
-
- ```bash
- ./build/mvn -Phive package
- ```
+```bash
+./build/mvn -Phive clean package
+```
- or
+or
- ```bash
- ./build/sbt -Phive package
- ```
+```bash
+./build/sbt -Phive clean package
+```
## Run Spark Shell
+To run Spark Connect you locally built:
+
+```bash
+# Scala shell
+./bin/spark-shell \
+ --jars `ls connector/connect/target/**/spark-connect*SNAPSHOT.jar | paste -sd ',' -` \
+ --conf spark.plugins=org.apache.spark.sql.connect.SparkConnectPlugin
+
+# PySpark shell
+./bin/pyspark \
+ --jars `ls connector/connect/target/**/spark-connect*SNAPSHOT.jar | paste -sd ',' -` \
+ --conf spark.plugins=org.apache.spark.sql.connect.SparkConnectPlugin
+```
+
+To use the release version of Spark Connect:
+
```bash
./bin/spark-shell \
--packages org.apache.spark:spark-connect_2.12:3.4.0 \
Review Comment:
Is this the preferred way of doing it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on a diff in pull request #38236: [MINOR][DOCS][CONNECT] Fix docs to run Spark Connect locally built
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on code in PR #38236:
URL: https://github.com/apache/spark/pull/38236#discussion_r994267736
##########
python/pyspark/sql/connect/README.md:
##########
@@ -9,22 +9,34 @@ of Spark. To enable it, you only need to activate the driver plugin for Spark Co
## Build
-1. Build Spark as usual per the documentation.
-
-2. Build and package the Spark Connect package
-
- ```bash
- ./build/mvn -Phive package
- ```
+```bash
+./build/mvn -Phive clean package
+```
- or
+or
- ```bash
- ./build/sbt -Phive package
- ```
+```bash
+./build/sbt -Phive clean package
+```
## Run Spark Shell
+To run Spark Connect you locally built:
+
+```bash
+# Scala shell
+./bin/spark-shell \
+ --jars `ls connector/connect/target/**/spark-connect*SNAPSHOT.jar | paste -sd ',' -` \
+ --conf spark.plugins=org.apache.spark.sql.connect.SparkConnectPlugin
+
+# PySpark shell
+./bin/pyspark \
+ --jars `ls connector/connect/target/**/spark-connect*SNAPSHOT.jar | paste -sd ',' -` \
+ --conf spark.plugins=org.apache.spark.sql.connect.SparkConnectPlugin
+```
+
+To use the release version of Spark Connect:
+
```bash
./bin/spark-shell \
--packages org.apache.spark:spark-connect_2.12:3.4.0 \
Review Comment:
Yup, the user-facing documentation will only have this alone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #38236: [MINOR][DOCS][CONNECT] Fix docs to run Spark Connect locally built
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #38236: [MINOR][DOCS][CONNECT] Fix docs to run Spark Connect locally built
URL: https://github.com/apache/spark/pull/38236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #38236: [MINOR][DOCS][CONNECT] Fix docs to run Spark Connect locally built
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38236:
URL: https://github.com/apache/spark/pull/38236#issuecomment-1277167725
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org