You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/03/02 14:34:00 UTC
[jira] [Commented] (FLINK-8623)
ConnectionUtilsTest.testReturnLocalHostAddressUsingHeuristics unstable on
Travis
[ https://issues.apache.org/jira/browse/FLINK-8623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383644#comment-16383644 ]
ASF GitHub Bot commented on FLINK-8623:
---------------------------------------
Github user NicoK commented on a diff in the pull request:
https://github.com/apache/flink/pull/5449#discussion_r171858504
--- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/net/ConnectionUtilsTest.java ---
@@ -61,7 +61,7 @@ public void testReturnLocalHostAddressUsingHeuristics() throws Exception {
assertNotNull(add);
// make sure that we returned the InetAddress.getLocalHost as a heuristic
- assertEquals(InetAddress.getLocalHost(), add);
+ assertEquals(InetAddress.getByName("localhost"), add);
--- End diff --
How about also changing the blocker above to accept connections on any interface just to rule accidental successful resolve attempts out, too, i.e. using `ServerSocket blocker = new ServerSocket(0, 1, null)`?
> ConnectionUtilsTest.testReturnLocalHostAddressUsingHeuristics unstable on Travis
> --------------------------------------------------------------------------------
>
> Key: FLINK-8623
> URL: https://issues.apache.org/jira/browse/FLINK-8623
> Project: Flink
> Issue Type: Bug
> Components: Tests
> Affects Versions: 1.5.0
> Reporter: Till Rohrmann
> Priority: Blocker
> Labels: test-stability
> Fix For: 1.5.0, 1.4.3
>
>
> {{ConnectionUtilsTest.testReturnLocalHostAddressUsingHeuristics}} fails on Travis: https://travis-ci.org/apache/flink/jobs/339344442
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)