[impala] branch master updated: IMPALA-11242: Impala cluster doesn't start when building with debug_noopt

[wz...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

wzhou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/impala.git


The following commit(s) were added to refs/heads/master by this push:
     new 8910f62ba IMPALA-11242: Impala cluster doesn't start when building with debug_noopt
8910f62ba is described below

commit 8910f62ba3200657186c35eb516ac9bb41a684e1
Author: Daniel Becker <da...@cloudera.com>
AuthorDate: Wed Apr 13 13:46:50 2022 +0200

    IMPALA-11242: Impala cluster doesn't start when building with debug_noopt
    
    IMPALA-11110 added the 'debug_noopt' build option but after building
    Impala with it, starting the Impala cluster fails:
    
    [...]
    File "/home/user/Impala/tests/common/environ.py", line 196, in
    validate_build_flags
        raise Exception("Unknown build type {0}".format(build_type))
    Exception: Unknown build type debug_noopt
    
    Adding a new 'DEBUG_NOOPT' entry to 'VALID_BUILD_TYPES' in
    tests/common/environ.py solves the issue.
    
    Change-Id: I388c24f7ed194eac73cecf041a0337a87bd806f6
    Reviewed-on: http://gerrit.cloudera.org:8080/18412
    Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
    Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
 buildall.sh             | 2 ++
 tests/common/environ.py | 6 ++++--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/buildall.sh b/buildall.sh
index 58ae33928..dccf52c90 100755
--- a/buildall.sh
+++ b/buildall.sh
@@ -86,6 +86,8 @@ export MAKE_CMD=make
 : ${CMAKE_BUILD_TYPE:=Debug}
 
 # parse command line options
+# Note: if you add a new build type, please also add it to 'VALID_BUILD_TYPES' in
+# tests/common/environ.py.
 while [ -n "$*" ]
 do
   case "$1" in
diff --git a/tests/common/environ.py b/tests/common/environ.py
index 59df36328..e62eb87c3 100644
--- a/tests/common/environ.py
+++ b/tests/common/environ.py
@@ -105,6 +105,8 @@ class ImpalaBuildFlavors:
   ADDRESS_SANITIZER = 'address_sanitizer'
   # ./buildall.sh
   DEBUG = 'debug'
+  # ./buildall.sh -debug_noopt
+  DEBUG_NOOPT = 'debug_noopt'
   # ./buildall.sh -release
   RELEASE = 'release'
   # ./buildall.sh -codecoverage
@@ -122,8 +124,8 @@ class ImpalaBuildFlavors:
   # ./buildall.sh -full_ubsan
   UBSAN_FULL = 'ubsan_full'
 
-  VALID_BUILD_TYPES = [ADDRESS_SANITIZER, DEBUG, CODE_COVERAGE_DEBUG, RELEASE,
-      CODE_COVERAGE_RELEASE, TIDY, TSAN, TSAN_FULL, UBSAN, UBSAN_FULL]
+  VALID_BUILD_TYPES = [ADDRESS_SANITIZER, DEBUG, DEBUG_NOOPT, CODE_COVERAGE_DEBUG,
+       RELEASE, CODE_COVERAGE_RELEASE, TIDY, TSAN, TSAN_FULL, UBSAN, UBSAN_FULL]
 
 
 class LinkTypes: