You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "turboFei (via GitHub)" <gi...@apache.org> on 2024/10/11 04:27:24 UTC

[PR] Peer raft [celeborn]

turboFei opened a new pull request, #2804:
URL: https://github.com/apache/celeborn/pull/2804

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
     - Be sure to keep the PR description updated to reflect all changes.
     - Please write your PR title to summarize what this PR proposes.
     - If possible, provide a concise example to reproduce the issue for a faster review.
   -->
   
   ### What changes were proposed in this pull request?
   
   
   
   ### Why are the changes needed?
   
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   
   
   ### How was this patch tested?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1630] Support to apply ratis peer operation with RESTful api [celeborn]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #2804:
URL: https://github.com/apache/celeborn/pull/2804#discussion_r1802225408


##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -2655,6 +2657,14 @@ object CelebornConf extends Logging {
       .timeConf(TimeUnit.SECONDS)
       .createWithDefaultString("5s")
 
+  val HA_MASTER_RATIS_LEADER_ELECTION_MEMBER_MAJORITY_ADD: ConfigEntry[Boolean] =

Review Comment:
   > Maybe default as true is more reasonable than false
   Have set the default value to true.
   
   > do we need guarantee this value should be true?
   
   Yes,  I have checked it in 
   ```
   private def ensureLeaderElectionMemberMajorityAddEnabled[T](master: Master)(f: => T): T = {
       ensureMasterIsLeader(master) {
         if (!master.conf.hasMasterRatisLeaderElectionMemberMajorityAdd) {
           throw new BadRequestException(s"This operation can only be done when" +
             s" ${CelebornConf.HA_MASTER_RATIS_LEADER_ELECTION_MEMBER_MAJORITY_ADD.key} is true.")
         }
         f
       }
     }
   ```
   
   >  seems majority-add default is false in ratis.
   Yes.
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1630] Support to apply ratis peer operation with RESTful api [celeborn]

Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong closed pull request #2804: [CELEBORN-1630] Support to apply ratis peer operation with RESTful api
URL: https://github.com/apache/celeborn/pull/2804


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [CELEBORN-1630] Support to apply ratis peer operation with RESTful api [celeborn]

Posted by "RexXiong (via GitHub)" <gi...@apache.org>.
RexXiong commented on code in PR #2804:
URL: https://github.com/apache/celeborn/pull/2804#discussion_r1800595280


##########
common/src/main/scala/org/apache/celeborn/common/CelebornConf.scala:
##########
@@ -2655,6 +2657,14 @@ object CelebornConf extends Logging {
       .timeConf(TimeUnit.SECONDS)
       .createWithDefaultString("5s")
 
+  val HA_MASTER_RATIS_LEADER_ELECTION_MEMBER_MAJORITY_ADD: ConfigEntry[Boolean] =

Review Comment:
   Maybe default as true is more reasonable then false, and do we need guarantee this value should be true? seems majority-add default is false in ratis.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org