You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by agoodm <gi...@git.apache.org> on 2016/11/13 18:18:53 UTC

[GitHub] zeppelin pull request #1626: [ZEPPELIN-1655] Dynamic forms in Python interpr...

GitHub user agoodm opened a pull request:

    https://github.com/apache/zeppelin/pull/1626

    [ZEPPELIN-1655] Dynamic forms in Python interpreter do not work

    ### What is this PR for?
    After #1534 , Dynamic Forms were no longer working in the python interpreter. This is because the `Py4jZeppelinContext` constructor did not initialize the `_displayhook` which is always called on post-execute.
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    [ZEPPELIN-1655](https://issues.apache.org/jira/browse/ZEPPELIN-1655)
    
    ### How should this be tested?
    Run the following `%python` paragraph, being sure that Py4j is installed:
    ```python
    %python
    a, b, c, = (1, 2, 3)
    z.select("Choose a letter", ([a,"a"], [b,"b"], [c,"c"] ))
    ```
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/agoodm/zeppelin ZEPPELIN-1655

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1626.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1626
    
----
commit 2e4ee2dd41314cb2f1f7c999484397d0f0b791b3
Author: Alex Goodman <ag...@users.noreply.github.com>
Date:   2016-11-13T18:10:50Z

    Make sure _displayhook is initialized in Py4jZeppelinContext

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1626: [ZEPPELIN-1655] Dynamic forms in Python interpreter do...

Posted by agoodm <gi...@git.apache.org>.

Github user agoodm commented on the issue:

    https://github.com/apache/zeppelin/pull/1626
  
    Here you go @bzz !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1626: [ZEPPELIN-1655] Dynamic forms in Python interpr...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1626


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1626: [ZEPPELIN-1655] Dynamic forms in Python interpreter do...

Posted by bzz <gi...@git.apache.org>.

Github user bzz commented on the issue:

    https://github.com/apache/zeppelin/pull/1626
  
    Thank you for the prompt update @agoodm 
    
    CI failure on Selenium test profile seem un-related:
    
    ```
    Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 129.268 sec - in org.apache.zeppelin.integration.ZeppelinIT
    
    Results :
    
    Failed tests: 
      AuthenticationIT.startUp:95 null
    
    Tests run: 17, Failures: 1, Errors: 0, Skipped: 0
    ```
    
    Looks gearat to me, merging to master as a hotfix, if there is no further discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---