You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/05/15 09:42:37 UTC
[GitHub] [incubator-pekko] mdedetrich opened a new pull request, #319: Integrate sbt-license-report
mdedetrich opened a new pull request, #319:
URL: https://github.com/apache/incubator-pekko/pull/319
This PR integrates the latest release of [sbt-license-report](https://github.com/sbt/sbt-license-report) into Pekko docs. This is done by using paradox's source generator support (see https://developer.lightbend.com/docs/paradox/current/customization/generators.html), the integration is quite straight forward due to the fact that sbt-license-report generates markdown format. In summary the whole process is entirely automated, when you run `paradox/docs` the report will be there for you and one can always manually run the various sbt license-report tasks manually (such as `dumpLicenseReportAggregate`).
In addition, this PR removes the license comments in `project/Dependencies.scala` since the whole point of sbt-license-report is to automate this (and it also does it correctly since it inspects the internal dependency resolution that SBT performs).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #319: Integrate sbt-license-report
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #319:
URL: https://github.com/apache/incubator-pekko/pull/319#issuecomment-1547541861
@pjfanning I just edited the original post, do you have any comments regarding the configuration options or is this good for now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich merged pull request #319: Integrate sbt-license-report
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich merged PR #319:
URL: https://github.com/apache/incubator-pekko/pull/319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] pjfanning commented on pull request #319: Integrate sbt-license-report
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #319:
URL: https://github.com/apache/incubator-pekko/pull/319#issuecomment-1547550825
> @pjfanning I just edited the original post, do you have any comments regarding the configuration options or is this good for now?
the PR and description are fine as far as I am concerned
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] raboof commented on a diff in pull request #319: Integrate sbt-license-report
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on code in PR #319:
URL: https://github.com/apache/incubator-pekko/pull/319#discussion_r1193608307
##########
project/Dependencies.scala:
##########
@@ -75,44 +75,44 @@ object Dependencies {
object Compile {
// Compile
- val config = "com.typesafe" % "config" % "1.4.2" // ApacheV2
- val netty = "io.netty" % "netty" % nettyVersion // ApacheV2
+ val config = "com.typesafe" % "config" % "1.4.2"
Review Comment:
These are occasionally useful when deciding whether it's OK to use a Test dependency as a Compile dependency as well, or to check whether an upstream license change was carefully considered. I'm OK with dropping them though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #319: Integrate sbt-license-report
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #319:
URL: https://github.com/apache/incubator-pekko/pull/319#discussion_r1193614578
##########
project/Dependencies.scala:
##########
@@ -75,44 +75,44 @@ object Dependencies {
object Compile {
// Compile
- val config = "com.typesafe" % "config" % "1.4.2" // ApacheV2
- val netty = "io.netty" % "netty" % nettyVersion // ApacheV2
+ val config = "com.typesafe" % "config" % "1.4.2"
Review Comment:
It sounds to me a better solution to this problem would be to add functionality into `sbt-license-report` to throw an error if ucategorized licenses are found (uncategorized is the fallback for when no license is detected). This can work in conjunction with `licenseFilter`. That way if a non OS license is found (by someone adding a dependency) the CI will fail, and then they have to explicitly handle it with `licenseOverrides`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on a diff in pull request #319: Integrate sbt-license-report
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #319:
URL: https://github.com/apache/incubator-pekko/pull/319#discussion_r1193614578
##########
project/Dependencies.scala:
##########
@@ -75,44 +75,44 @@ object Dependencies {
object Compile {
// Compile
- val config = "com.typesafe" % "config" % "1.4.2" // ApacheV2
- val netty = "io.netty" % "netty" % nettyVersion // ApacheV2
+ val config = "com.typesafe" % "config" % "1.4.2"
Review Comment:
It sounds to me a better solution to this problem would be to add functionality into `sbt-license-report` to throw an error if ucategorized licenses are found (uncategorized is the fallback for when no license is detected). This can work in conjunction with `licenseFilter`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org