[GitHub] rabbah commented on a change in pull request #2357: Cli should ignore a config file env variable value of empty string

[gi...@git.apache.org]

rabbah commented on a change in pull request #2357: Cli should ignore a config file env variable value of empty string
URL: https://github.com/apache/incubator-openwhisk/pull/2357#discussion_r121432335
 
 

 ##########
 File path: tests/src/test/scala/common/Wsk.scala
 ##########
 @@ -869,7 +869,8 @@ class WskApi()
             { apiname map { a => Seq("--apiname", a) } getOrElse Seq() } ++
             { swagger map { s => Seq("--config-file", s) } getOrElse Seq() } ++
             { responsetype map { t => Seq("--response-type", t) } getOrElse Seq() }
-        cli(wp.overrides ++ params, expectedExitCode, showCmd = true, env=Map("WSK_CONFIG_FILE" -> cliCfgFile.getOrElse("")))
+        val envMap = { cliCfgFile map {f => Map("WSK_CONFIG_FILE" -> f) } getOrElse Map() }
 
 Review comment:
   these changes should be backed out also (to prevent collision with local prop files for testings). the overrides are supposed to cover all the relevant variables but this is an extra precaution. Do you think we should not do this?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services