[GitHub] [accumulo-testing] EdColeman commented on a change in pull request #166: Add deletes to continuous ingest

[GitBox <gi...@apache.org>]

EdColeman commented on a change in pull request #166:
URL: https://github.com/apache/accumulo-testing/pull/166#discussion_r749659432



##########
File path: src/main/java/org/apache/accumulo/testing/continuous/ContinuousIngest.java
##########
@@ -64,6 +64,14 @@ private static boolean pauseEnabled(Properties props) {
     return Boolean.parseBoolean(value);
   }
 
+  private static int getDeleteProbability(Properties props) {

Review comment:
       Did you consider using a floating point value instead of an integer?  Being this is being passed in as a String from props it might not matter - but I think it is more common to be able to specify a probability as a ratio, say 1/10 or 1/2 (or 0.1 or 0.5) - for example [Open Tracing Sampling](https://opentelemetry-python.readthedocs.io/en/latest/sdk/trace.sampling.html)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org