You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/06/29 10:57:24 UTC
[GitHub] [apisix] mikawudi opened a new pull request, #7355: feat: add hostname config
mikawudi opened a new pull request, #7355:
URL: https://github.com/apache/apisix/pull/7355
hostname use to tag the node
config it in local config file is easy then change server hostname.....
and sometime we can‘t change the server’s hostname
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tokers commented on pull request #7355: feat: add hostname config
Posted by GitBox <gi...@apache.org>.
tokers commented on PR #7355:
URL: https://github.com/apache/apisix/pull/7355#issuecomment-1170646799
@mikawudi Could you add some test cases to cover it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] mikawudi commented on a diff in pull request #7355: feat: add hostname config
Posted by GitBox <gi...@apache.org>.
mikawudi commented on code in PR #7355:
URL: https://github.com/apache/apisix/pull/7355#discussion_r912704984
##########
apisix/core/utils.lua:
##########
@@ -253,6 +253,13 @@ function _M.gethostname()
return hostname
end
+ local local_conf = config_local.local_conf()
Review Comment:
emm,英文不大好,描述不清晰撒
我们存在这种场景,以前有的机器没修改过hostname,阿里云默认给的是一堆乱码,然后这个乱码的host被别的组拿去解析了,现在没法修改hostname,然后apisix部署在这个机器上...日志里面的和dashboard里看到的hostname就都是乱码了,确实场景不是很合适的话我这边直接把pr关了撒~周五周六忙apisix落地没啥时间回复信息,见谅~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] mikawudi closed pull request #7355: feat: add hostname config
Posted by GitBox <gi...@apache.org>.
mikawudi closed pull request #7355: feat: add hostname config
URL: https://github.com/apache/apisix/pull/7355
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] mikawudi commented on pull request #7355: feat: add hostname config
Posted by GitBox <gi...@apache.org>.
mikawudi commented on PR #7355:
URL: https://github.com/apache/apisix/pull/7355#issuecomment-1170698302
@tokers any docs for write test?.......i can't understanding the program language of .t file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] mikawudi commented on a diff in pull request #7355: feat: add hostname config
Posted by GitBox <gi...@apache.org>.
mikawudi commented on code in PR #7355:
URL: https://github.com/apache/apisix/pull/7355#discussion_r912704984
##########
apisix/core/utils.lua:
##########
@@ -253,6 +253,13 @@ function _M.gethostname()
return hostname
end
+ local local_conf = config_local.local_conf()
Review Comment:
emm,英文不大好,描述不清晰撒
我们存在这种场景,以前有的机器没修改过hostname,阿里云默认给的是一堆乱码,然后这个乱码的host被别的组拿去解析了,现在没法修改hostname,然后apisix部署在这个机器上...日志里面的和dashboard里看到的hostname就都是乱码了,确实场景不是很合适的话我这边直接把pr关了撒,周五周六忙apisix落地没啥时间回复信息,见谅~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a diff in pull request #7355: feat: add hostname config
Posted by GitBox <gi...@apache.org>.
spacewander commented on code in PR #7355:
URL: https://github.com/apache/apisix/pull/7355#discussion_r910622045
##########
apisix/core/utils.lua:
##########
@@ -253,6 +253,13 @@ function _M.gethostname()
return hostname
end
+ local local_conf = config_local.local_conf()
Review Comment:
Why do we need to configure the hostname in an API gateway instead of the environment it is running on? This way is an anti-pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a diff in pull request #7355: feat: add hostname config
Posted by GitBox <gi...@apache.org>.
tzssangglass commented on code in PR #7355:
URL: https://github.com/apache/apisix/pull/7355#discussion_r911555398
##########
apisix/core/utils.lua:
##########
@@ -253,6 +253,13 @@ function _M.gethostname()
return hostname
end
+ local local_conf = config_local.local_conf()
Review Comment:
In some runtime scenarios, the hostname is not known before startup, but only at runtime, and the hostname cannot be configured before startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org