You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "java-codehunger (via GitHub)" <gi...@apache.org> on 2023/03/30 02:43:57 UTC
[GitHub] [shardingsphere-elasticjob] java-codehunger opened a new pull request, #2202: Making Test less flaky
java-codehunger opened a new pull request, #2202:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2202
This test is sometimes failing because in the code-under-test some threads slows down the return of workQueue.size() . Hence, the error occurs.
Changes proposed in this pull request:
Failure-Log:
Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 2.698 s <<< FAILURE! - in org.apache.shardingsphere.elasticjob.infra.concurrent.ElasticJobExecutorServiceTest
[ERROR] assertCreateExecutorService(org.apache.shardingsphere.elasticjob.infra.concurrent.ElasticJobExecutorServiceTest) Time elapsed: 2.654 s <<< FAILURE!
java.lang.AssertionError:
Expected: is <1>
but: was <0>
at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
at org.junit.Assert.assertThat(Assert.java:956)
at org.junit.Assert.assertThat(Assert.java:923)
at org.apache.shardingsphere.elasticjob.infra.concurrent.ElasticJobExecutorServiceTest.assertCreateExecutorService(ElasticJobExecutorServiceTest.java:46)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)
-
-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-commenter commented on pull request #2202: Making Test less flaky
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #2202:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2202#issuecomment-1490531236
## [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2202?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2202](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2202?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (52a36fc) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/5297e2f65c70bbf9ae3545d3142ed69bb34e14d4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5297e2f) will **increase** coverage by `0.06%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #2202 +/- ##
============================================
+ Coverage 84.51% 84.58% +0.06%
- Complexity 1917 1918 +1
============================================
Files 287 287
Lines 6291 6291
Branches 696 696
============================================
+ Hits 5317 5321 +4
+ Misses 653 649 -4
Partials 321 321
```
[see 1 file with indirect coverage changes](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/2202/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] linghengqian commented on pull request #2202: Making Test less flaky
Posted by "linghengqian (via GitHub)" <gi...@apache.org>.
linghengqian commented on PR #2202:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2202#issuecomment-1716758486
> * I think [Fix Test Flakiness #2242](https://github.com/apache/shardingsphere-elasticjob/pull/2242) is relatively more reasonable, and in the long run, I tend to introduce https://github.com/awaitility/awaitility .
- I created https://github.com/apache/shardingsphere-elasticjob/pull/2257 to fundamentally solve this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] strongduanmu closed pull request #2202: Making Test less flaky
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu closed pull request #2202: Making Test less flaky
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org