Re: [PR] Add GitHub Enterprise support to GitHub App authentication in the git provider [airflow]

["jeff3071 (via GitHub)" <gi...@apache.org>]

jeff3071 commented on code in PR #72865:
URL: https://github.com/apache/airflow/pull/72865#discussion_r4082178198


##########
providers/git/src/airflow/providers/git/hooks/git.py:
##########
@@ -88,6 +93,7 @@ def get_ui_field_behaviour(cls) -> dict[str, Any]:
                         "ssh_port": "",
                         "github_app_id": "",
                         "github_installation_id": "",
+                        "github_api_url": "",

Review Comment:
   Could you also add `github_api_url` to `providers/git/provider.yaml` and regenerate `get_provider_info.py`? 
   
   `ProvidersManager` loads the existing `ui-field-behaviour` from packaged provider metadata and therefore skips this hook method, so the new placeholder will not appear in the connection UI as written.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org