You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2008/05/20 09:34:01 UTC
svn commit: r658132 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt
Date: Tue May 20 00:34:01 2008
New Revision: 658132
URL: http://svn.apache.org/viewvc?rev=658132&view=rev
Log:
Add some comments to Remy's -1s
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=658132&r1=658131&r2=658132&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue May 20 00:34:01 2008
@@ -68,6 +68,8 @@
+1: markt
-1: remm (I think it is a good patch, but it throws an error for something which was working before,
so I would think keeping it for the next release would be better)
+ markt How about making it optional with a system property that can be used
+ to restore the current behaviour is an app depends on it?
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44994
Correct BNF grammar so ${0 lt a ? 1 lt a ? "many": "one": "none"} works
@@ -93,6 +95,10 @@
it may not apply to HTTP/1.1, which may be more strict; passing full URLs in the
request line is normally an HTTP/1.1 thing, from what I remember, usable as an alternative
to the mandatory Host header)
+ markt Both the HTTP/1.1 and HTTP/1.0 contain broadly the same text
+ regarding tolerant applications. (ie allow multiple SP/HT between
+ method-url and url-httpVersion). However, it is optional so we don't
+ have to support it.
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42747
Use any META-INF/context.xml in a consistent manner and ensure it is used on
@@ -100,3 +106,6 @@
http://svn.apache.org/viewvc?rev=657995&view=rev
+1: markt
-1: remm (would need convincing that this is really well tested, otherwise delay to next release)
+ markt Exactly what would convince you that this was well tested above and
+ beyond the local testing that I have done to convince myself that
+ this patch does what I want it to.
\ No newline at end of file
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r658132 - /tomcat/tc6.0.x/trunk/STATUS.txt
Posted by Mark Thomas <ma...@apache.org>.
Remy Maucherat wrote:
> On Tue, 2008-05-20 at 07:34 +0000, markt@apache.org wrote:
>> Author: markt
>> Date: Tue May 20 00:34:01 2008
>> New Revision: 658132
>>
>> URL: http://svn.apache.org/viewvc?rev=658132&view=rev
>> Log:
>> Add some comments to Remy's -1s
>> -1: remm (I think it is a good patch, but it throws an error for something which was working before,
>> so I would think keeping it for the next release would be better)
>> + markt How about making it optional with a system property that can be used
>> + to restore the current behaviour is an app depends on it?
>
> Ok.
I'll get that done in the next couple of days and update the patch.
Mark
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
Re: svn commit: r658132 - /tomcat/tc6.0.x/trunk/STATUS.txt
Posted by Remy Maucherat <re...@apache.org>.
On Tue, 2008-05-20 at 07:34 +0000, markt@apache.org wrote:
> Author: markt
> Date: Tue May 20 00:34:01 2008
> New Revision: 658132
>
> URL: http://svn.apache.org/viewvc?rev=658132&view=rev
> Log:
> Add some comments to Remy's -1s
> -1: remm (I think it is a good patch, but it throws an error for something which was working before,
> so I would think keeping it for the next release would be better)
> + markt How about making it optional with a system property that can be used
> + to restore the current behaviour is an app depends on it?
Ok.
> * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=44994
> Correct BNF grammar so ${0 lt a ? 1 lt a ? "many": "one": "none"} works
> @@ -93,6 +95,10 @@
> it may not apply to HTTP/1.1, which may be more strict; passing full URLs in the
> request line is normally an HTTP/1.1 thing, from what I remember, usable as an alternative
> to the mandatory Host header)
> + markt Both the HTTP/1.1 and HTTP/1.0 contain broadly the same text
> + regarding tolerant applications. (ie allow multiple SP/HT between
> + method-url and url-httpVersion). However, it is optional so we don't
> + have to support it.
What does httpd do about that BTW ?
> * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=42747
> Use any META-INF/context.xml in a consistent manner and ensure it is used on
> @@ -100,3 +106,6 @@
> http://svn.apache.org/viewvc?rev=657995&view=rev
> +1: markt
> -1: remm (would need convincing that this is really well tested, otherwise delay to next release)
> + markt Exactly what would convince you that this was well tested above and
> + beyond the local testing that I have done to convince myself that
> + this patch does what I want it to.
It's a start.
Rémy
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org