You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2015/12/03 00:48:35 UTC

Review Request 40888: Add volume driver plugin to mesos v1 proto.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40888/
-----------------------------------------------------------

Review request for mesos, haosdent huang, Artem Harutyunyan, and Timothy Chen.


Repository: mesos


Description
-------

Add volume driver plugin to mesos v1 proto.


Diffs
-----

  include/mesos/v1/mesos.proto 9acefd55603a5a4f3f08a879a380ff927fd1e0dd 

Diff: https://reviews.apache.org/r/40888/diff/


Testing
-------

make check(ubuntu14.04 + clang-3.6)


Thanks,

Gilbert Song


Re: Review Request 40888: Add volume driver plugin to mesos v1 proto.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40888/#review108763
-----------------------------------------------------------


Patch looks great!

Reviews applied: [40888]

Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh

- Mesos ReviewBot


On Dec. 2, 2015, 11:48 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40888/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2015, 11:48 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Artem Harutyunyan, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add volume driver plugin to mesos v1 proto.
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/mesos.proto 9acefd55603a5a4f3f08a879a380ff927fd1e0dd 
> 
> Diff: https://reviews.apache.org/r/40888/diff/
> 
> 
> Testing
> -------
> 
> make check(ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Re: Review Request 40888: Add volume driver plugin to mesos v1 proto.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40888/#review108766
-----------------------------------------------------------

Ship it!


Ship It!

- Guangya Liu


On 十二月 2, 2015, 11:48 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40888/
> -----------------------------------------------------------
> 
> (Updated 十二月 2, 2015, 11:48 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Artem Harutyunyan, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add volume driver plugin to mesos v1 proto.
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/mesos.proto 9acefd55603a5a4f3f08a879a380ff927fd1e0dd 
> 
> Diff: https://reviews.apache.org/r/40888/diff/
> 
> 
> Testing
> -------
> 
> make check(ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>


Re: Review Request 40888: Add volume driver plugin to mesos v1 proto.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40888/#review109259
-----------------------------------------------------------

Ship it!


Ship It!

- Till Toenshoff


On Dec. 2, 2015, 11:48 p.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40888/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2015, 11:48 p.m.)
> 
> 
> Review request for mesos, haosdent huang, Artem Harutyunyan, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Add volume driver plugin to mesos v1 proto.
> 
> 
> Diffs
> -----
> 
>   include/mesos/v1/mesos.proto 9acefd55603a5a4f3f08a879a380ff927fd1e0dd 
> 
> Diff: https://reviews.apache.org/r/40888/diff/
> 
> 
> Testing
> -------
> 
> make check(ubuntu14.04 + clang-3.6)
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>