You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/01/07 15:32:15 UTC
[GitHub] [beam] sonam-vend commented on a change in pull request #13660: Enabed strict dependecy on Google Cloud Dataflow runner
sonam-vend commented on a change in pull request #13660:
URL: https://github.com/apache/beam/pull/13660#discussion_r553401201
##########
File path: runners/google-cloud-dataflow-java/worker/windmill/build.gradle
##########
@@ -36,3 +36,39 @@ configurations {
artifacts {
unshaded jar
}
+
+dependencies {
+ compile "com.google.guava:guava:28.1-android"
+ permitUnusedDeclared library.java.vendored_grpc_1_26_0
+ permitUnusedDeclared library.java.error_prone_annotations
+ permitUnusedDeclared "com.github.jponge:lzma-java:1.3"
+ permitUnusedDeclared "com.google.api.grpc:proto-google-common-protos:1.12.0"
+ permitUnusedDeclared library.java.google_code_gson
+ permitUnusedDeclared library.java.guava
+ permitUnusedDeclared library.java.grpc_context
+ permitUnusedDeclared library.java.grpc_core
+ permitUnusedDeclared library.java.slf4j_api
+ permitUnusedDeclared "com.google.protobuf.nano:protobuf-javanano:3.0.0-alpha-5"
+ permitUnusedDeclared "com.google.protobuf:protobuf-java-util:3.11.0"
+ permitUnusedDeclared "com.jcraft:jzlib:1.1.3"
+ permitUnusedDeclared "com.ning:compress-lzf:1.0.3"
+ permitUnusedDeclared "commons-logging:commons-logging:1.2"
+ permitUnusedDeclared "io.grpc:grpc-testing:1.26.0"
+ permitUnusedDeclared "io.netty:netty-tcnative-boringssl-static:2.0.33.Final"
+ permitUnusedDeclared "io.netty:netty-transport-native-epoll:4.1.51.Final"
+ permitUnusedDeclared "io.opencensus:opencensus-api:0.24.0"
+ permitUnusedDeclared "io.opencensus:opencensus-contrib-grpc-metrics:0.24.0"
+ permitUnusedDeclared "io.perfmark:perfmark-api:0.19.0"
+ permitUnusedDeclared "net.jpountz.lz4:lz4:1.3.0"
+ permitUnusedDeclared "org.apache.logging.log4j:log4j-api:2.6.2"
+ permitUnusedDeclared "org.bouncycastle:bcpkix-jdk15on:1.54"
+ permitUnusedDeclared "org.bouncycastle:bcprov-jdk15on:1.54"
+ permitUnusedDeclared "org.conscrypt:conscrypt-openjdk-uber:2.5.1"
+ permitUnusedDeclared "org.eclipse.jetty.alpn:alpn-api:1.1.2.v20150522"
+ permitUnusedDeclared "org.eclipse.jetty.npn:npn-api:1.1.1.v20141010"
+ permitUnusedDeclared "org.jboss.marshalling:jboss-marshalling:1.4.11.Final"
+ permitUnusedDeclared "org.jboss.modules:jboss-modules:1.1.0.Beta1"
+ permitUnusedDeclared "com.google.auth:google-auth-library-credentials:0.18.0"
+ permitUnusedDeclared "io.grpc:grpc-auth:1.26.0"
+ permitUnusedDeclared "io.grpc:grpc-netty:1.26.0"
Review comment:
unusedDeclaredArtifacts:
- com.github.jponge:lzma-java:1.3@jar
- com.google.api.grpc:proto-google-common-protos:1.12.0@jar
- com.google.auth:google-auth-library-credentials:0.18.0@jar
- com.google.code.gson:gson:2.8.6@jar
- com.google.errorprone:error_prone_annotations:2.3.3@jar
- com.google.guava:guava:28.1-android@jar
- com.google.protobuf.nano:protobuf-javanano:3.0.0-alpha-5@jar
- com.google.protobuf:protobuf-java-util:3.11.0@jar
- com.jcraft:jzlib:1.1.3@jar
- com.ning:compress-lzf:1.0.3@jar
- commons-logging:commons-logging:1.2@jar
- io.grpc:grpc-auth:1.26.0@jar
- io.grpc:grpc-context:1.26.0@jar
- io.grpc:grpc-core:1.26.0@jar
- io.grpc:grpc-netty:1.26.0@jar
- io.grpc:grpc-testing:1.26.0@jar
- io.netty:netty-tcnative-boringssl-static:2.0.33.Final@jar
- io.netty:netty-transport-native-epoll:4.1.51.Final@jar
- io.opencensus:opencensus-api:0.24.0@jar
- io.opencensus:opencensus-contrib-grpc-metrics:0.24.0@jar
- io.perfmark:perfmark-api:0.19.0@jar
- net.jpountz.lz4:lz4:1.3.0@jar
- org.apache.beam:beam-vendor-grpc-1_26_0:0.3@jar
- org.apache.logging.log4j:log4j-api:2.6.2@jar
- org.bouncycastle:bcpkix-jdk15on:1.54@jar
- org.bouncycastle:bcprov-jdk15on:1.54@jar
- org.conscrypt:conscrypt-openjdk-uber:2.5.1@jar
- org.eclipse.jetty.alpn:alpn-api:1.1.2.v20150522@jar
- org.eclipse.jetty.npn:npn-api:1.1.1.v20141010@jar
- org.jboss.marshalling:jboss-marshalling:1.4.11.Final@jar
- org.jboss.modules:jboss-modules:1.1.0.Beta1@jar
- org.slf4j:slf4j-api:1.7.30@jar
This list of dependencies are transitively being called from GrpcVendoring_1_26_0.groovy, removing these dependencies from GrpcVendoring_1_26_0.groovy causes checks failures. So, Instead of removing it from GrpcVendoring_1_26_0.groovy, I permitted UnusedDeclaredArtifacts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org