[GitHub] [trafficcontrol] shamrickus commented on a change in pull request #4635: Interfaces first migration

[GitBox <gi...@apache.org>]

shamrickus commented on a change in pull request #4635: Interfaces first migration
URL: https://github.com/apache/trafficcontrol/pull/4635#discussion_r409010742
 
 

 ##########
 File path: traffic_ops/app/db/migrations/20200414000000_interfaces.sql
 ##########
 @@ -0,0 +1,151 @@
+/*
+	Licensed under the Apache License, Version 2.0 (the "License");
+	you may not use this file except in compliance with the License.
+	You may obtain a copy of the License at
+
+		http://www.apache.org/licenses/LICENSE-2.0
+
+	Unless required by applicable law or agreed to in writing, software
+	distributed under the License is distributed on an "AS IS" BASIS,
+	WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+	See the License for the specific language governing permissions and
+	limitations under the License.
+*/
+
+-- +goose Up
+CREATE TABLE interface (
+	max_bandwidth bigint DEFAULT NULL CHECK (max_bandwidth IS NULL OR max_bandwidth >= 0),
 
 Review comment:
   Blueprint specifies that the default for max_bandwidth should be 0

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services