You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/01/22 16:11:17 UTC
[GitHub] [flink] tillrohrmann opened a new pull request #10927:
[FLINK-14742][test] Harden TaskExecutorTest#testSubmitTaskBeforeAcceptSlot
tillrohrmann opened a new pull request #10927: [FLINK-14742][test] Harden TaskExecutorTest#testSubmitTaskBeforeAcceptSlot
URL: https://github.com/apache/flink/pull/10927
## What is the purpose of the change
Remove the access to TaskExecutor's internal state from the test thread. Instead we rely
on the public API of the TaskExecutorGateway and its collaborators to verify the test.
cc @kl0u
## Verifying this change
This PR hardens the above-mentioned test case. You can try this fix by running the test in a loop to see that it no longer fails.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on issue #10927: [FLINK-14742][test]
Harden TaskExecutorTest#testSubmitTaskBeforeAcceptSlot
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on issue #10927: [FLINK-14742][test] Harden TaskExecutorTest#testSubmitTaskBeforeAcceptSlot
URL: https://github.com/apache/flink/pull/10927#issuecomment-577676482
Thanks for the review @kl0u. The failure on Azure was a downloading problem. Merging this PR now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann closed pull request #10927:
[FLINK-14742][test] Harden TaskExecutorTest#testSubmitTaskBeforeAcceptSlot
Posted by GitBox <gi...@apache.org>.
tillrohrmann closed pull request #10927: [FLINK-14742][test] Harden TaskExecutorTest#testSubmitTaskBeforeAcceptSlot
URL: https://github.com/apache/flink/pull/10927
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10927: [FLINK-14742][test]
Harden TaskExecutorTest#testSubmitTaskBeforeAcceptSlot
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10927: [FLINK-14742][test] Harden TaskExecutorTest#testSubmitTaskBeforeAcceptSlot
URL: https://github.com/apache/flink/pull/10927#issuecomment-577284913
<!--
Meta data
Hash:7688b11719face9ba2b6c8b42461cc0159c1dfb3 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:7688b11719face9ba2b6c8b42461cc0159c1dfb3
-->
## CI report:
* 7688b11719face9ba2b6c8b42461cc0159c1dfb3 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10927:
[FLINK-14742][test] Harden TaskExecutorTest#testSubmitTaskBeforeAcceptSlot
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10927: [FLINK-14742][test] Harden TaskExecutorTest#testSubmitTaskBeforeAcceptSlot
URL: https://github.com/apache/flink/pull/10927#issuecomment-577284913
<!--
Meta data
Hash:7688b11719face9ba2b6c8b42461cc0159c1dfb3 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145595442 TriggerType:PUSH TriggerID:7688b11719face9ba2b6c8b42461cc0159c1dfb3
Hash:7688b11719face9ba2b6c8b42461cc0159c1dfb3 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4561 TriggerType:PUSH TriggerID:7688b11719face9ba2b6c8b42461cc0159c1dfb3
-->
## CI report:
* 7688b11719face9ba2b6c8b42461cc0159c1dfb3 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145595442) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4561)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] TisonKun commented on issue #10927: [FLINK-14742][test]
Harden TaskExecutorTest#testSubmitTaskBeforeAcceptSlot
Posted by GitBox <gi...@apache.org>.
TisonKun commented on issue #10927: [FLINK-14742][test] Harden TaskExecutorTest#testSubmitTaskBeforeAcceptSlot
URL: https://github.com/apache/flink/pull/10927#issuecomment-577533856
@flinkbot run azure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10927:
[FLINK-14742][test] Harden TaskExecutorTest#testSubmitTaskBeforeAcceptSlot
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10927: [FLINK-14742][test] Harden TaskExecutorTest#testSubmitTaskBeforeAcceptSlot
URL: https://github.com/apache/flink/pull/10927#issuecomment-577284913
<!--
Meta data
Hash:7688b11719face9ba2b6c8b42461cc0159c1dfb3 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/145595442 TriggerType:PUSH TriggerID:7688b11719face9ba2b6c8b42461cc0159c1dfb3
Hash:7688b11719face9ba2b6c8b42461cc0159c1dfb3 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4561 TriggerType:PUSH TriggerID:7688b11719face9ba2b6c8b42461cc0159c1dfb3
-->
## CI report:
* 7688b11719face9ba2b6c8b42461cc0159c1dfb3 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/145595442) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4561)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10927:
[FLINK-14742][test] Harden TaskExecutorTest#testSubmitTaskBeforeAcceptSlot
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10927: [FLINK-14742][test] Harden TaskExecutorTest#testSubmitTaskBeforeAcceptSlot
URL: https://github.com/apache/flink/pull/10927#issuecomment-577284913
<!--
Meta data
Hash:7688b11719face9ba2b6c8b42461cc0159c1dfb3 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145595442 TriggerType:PUSH TriggerID:7688b11719face9ba2b6c8b42461cc0159c1dfb3
Hash:7688b11719face9ba2b6c8b42461cc0159c1dfb3 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4561 TriggerType:PUSH TriggerID:7688b11719face9ba2b6c8b42461cc0159c1dfb3
Hash:7688b11719face9ba2b6c8b42461cc0159c1dfb3 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4561 TriggerType:MANUAL TriggerID:577533856
-->
## CI report:
* 7688b11719face9ba2b6c8b42461cc0159c1dfb3 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145595442) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4561)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #10927:
[FLINK-14742][test] Harden TaskExecutorTest#testSubmitTaskBeforeAcceptSlot
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #10927: [FLINK-14742][test] Harden TaskExecutorTest#testSubmitTaskBeforeAcceptSlot
URL: https://github.com/apache/flink/pull/10927#issuecomment-577284913
<!--
Meta data
Hash:7688b11719face9ba2b6c8b42461cc0159c1dfb3 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145595442 TriggerType:PUSH TriggerID:7688b11719face9ba2b6c8b42461cc0159c1dfb3
Hash:7688b11719face9ba2b6c8b42461cc0159c1dfb3 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4561 TriggerType:PUSH TriggerID:7688b11719face9ba2b6c8b42461cc0159c1dfb3
Hash:7688b11719face9ba2b6c8b42461cc0159c1dfb3 Status:FAILURE URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4561 TriggerType:MANUAL TriggerID:577533856
Hash:7688b11719face9ba2b6c8b42461cc0159c1dfb3 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/145595442 TriggerType:MANUAL TriggerID:577533856
-->
## CI report:
* 7688b11719face9ba2b6c8b42461cc0159c1dfb3 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/145595442) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4561)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #10927: [FLINK-14742][test]
Harden TaskExecutorTest#testSubmitTaskBeforeAcceptSlot
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #10927: [FLINK-14742][test] Harden TaskExecutorTest#testSubmitTaskBeforeAcceptSlot
URL: https://github.com/apache/flink/pull/10927#issuecomment-577262185
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 7688b11719face9ba2b6c8b42461cc0159c1dfb3 (Wed Jan 22 16:13:19 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services