You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Bernd Mathiske <be...@mesosphere.io> on 2015/12/03 11:12:55 UTC
Re: Review Request 40730: Fixing MESOS-3552 by using CHECK_NEAR to
avoid errors due to double precision errors.
> On Nov. 26, 2015, 6:43 a.m., Alexander Rukletsov wrote:
> > src/common/resources.cpp, line 35
> > <https://reviews.apache.org/r/40730/diff/1/?file=1147236#file1147236line35>
> >
> > Is it fine to include files from "master/" in "common/*"?
Addressed in https://reviews.apache.org/r/40767/
- Bernd
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40730/#review108132
-----------------------------------------------------------
On Nov. 25, 2015, 10:52 p.m., Avinash sridharan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40730/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2015, 10:52 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Klaus Ma, and Neil Conway.
>
>
> Bugs: MESOS-3552
> https://issues.apache.org/jira/browse/MESOS-3552
>
>
> Repository: mesos
>
>
> Description
> -------
>
> A version of this fix was already proposed by Mandeep Chadha (@mchadha) and submitted to the reivew board https://reviews.apache.org/r/39056/ . So the main credit should go to him for this fix.
>
>
> Diffs
> -----
>
> src/common/resources.cpp b4abf5405039d7d0a5028ccf034ad2e9623d064c
>
> Diff: https://reviews.apache.org/r/40730/diff/
>
>
> Testing
> -------
>
> Added Mandeep's test case to GTEST https://reviews.apache.org/r/39056/ and enabled an existing precision test (https://reviews.apache.org/r/40732/) to test this fix.
>
>
> Thanks,
>
> Avinash sridharan
>
>