[GitHub] [solr] chlorochrule commented on a diff in pull request #937: SOLR-16289: Null check in transformers of ltr module

[GitBox <gi...@apache.org>]

chlorochrule commented on code in PR #937:
URL: https://github.com/apache/solr/pull/937#discussion_r921117413


##########
solr/modules/ltr/src/test/org/apache/solr/ltr/TestLTROnSolrCloud.java:
##########
@@ -322,6 +323,29 @@ public void testSimpleQuery() throws Exception {
     assertEquals(result7_features, queryResponse.getResults().get(7).get("features").toString());
   }
 
+  @Test
+  public void testInterleaving() throws Exception {
+    SolrQuery query = new SolrQuery("{!func}sub(8,field(popularity))");
+    query.setRequestHandler("/query");
+    query.setFields("*,score,[interleaving]");
+    query.add("rq", "{!ltr model=powpularityS-model model=powpularityS-model-for-interleaving reRankDocs=8}");
+
+    solrCluster.getSolrClient().query(COLLECTION, query);  // NullPointerException at LTRInterleavingTransformerFactory.java:103
+  }

Review Comment:
   This test failed with NPE



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org