You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by GitBox <gi...@apache.org> on 2022/04/04 19:47:16 UTC
[GitHub] [thrift] jeking3 opened a new pull request, #2555: THRIFT-5546: automate pypi publishing [ci skip]
jeking3 opened a new pull request, #2555:
URL: https://github.com/apache/thrift/pull/2555
When a pre-release is created on GitHub for the repo it will publish to the TestPyPI service, and if that pre-release is promoted to a release, it will publish to the PyPI (real) service.
<!-- Explain the changes in the pull request below: -->
Using the technique described at https://cwiki.apache.org/confluence/display/BUILDS/GitHub+Actions+status to use third party github actions in the build.
Apache Infra team [added](https://issues.apache.org/jira/browse/INFRA-23070) the CLOUDTRUTH_API_KEY secret to the apache/thrift repo. Apache didn't have a way to help us manage our own deployment keys so I used a third party service to make it easier for us.
Here's a pre-release test build:
https://github.com/apache/thrift/actions/runs/2091974166
---
<!-- We recommend you review the checklist/tips before submitting a pull request. -->
- [X] Did you create an [Apache Jira](https://issues.apache.org/jira/projects/THRIFT/issues/) ticket? (not required for trivial changes)
- [X] If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
- [X] Did you squash your changes to a single commit? (not required, but preferred)
- [X] Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
- [X] If your change does not involve any code, include `[ci skip]` anywhere in the commit message to free up build resources.
<!--
The Contributing Guide at:
https://github.com/apache/thrift/blob/master/CONTRIBUTING.md
has more details and tips for committing properly.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] trams commented on pull request #2555: THRIFT-5546: automate pypi publishing [ci skip]
Posted by "trams (via GitHub)" <gi...@apache.org>.
trams commented on PR #2555:
URL: https://github.com/apache/thrift/pull/2555#issuecomment-1663090064
How can I help to make this possible? We would like to unblock thrift upgrades on our end
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] jeking3 commented on pull request #2555: THRIFT-5546: automate pypi publishing [ci skip]
Posted by GitBox <gi...@apache.org>.
jeking3 commented on PR #2555:
URL: https://github.com/apache/thrift/pull/2555#issuecomment-1291177920
This probably needs to change and put the pypi secrets into Apache's secret store directly so we can access them, instead of going through an intermediary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] trams commented on pull request #2555: THRIFT-5546: automate pypi publishing [ci skip]
Posted by "trams (via GitHub)" <gi...@apache.org>.
trams commented on PR #2555:
URL: https://github.com/apache/thrift/pull/2555#issuecomment-1663098582
I think now there is a way to declare a Github Action trusted and avoid adding tokens anywhere. See this documentation https://docs.pypi.org/trusted-publishers/using-a-publisher/
Their example is using pypa/gh-action-pypi-publish@release/v1 which I am not sure would work correctly with our thrift repo because we have a package inside lib/py not the root directory
But I think we are not limited to use only this GitHub action
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] SvenRoederer commented on pull request #2555: THRIFT-5546: automate pypi publishing [ci skip]
Posted by "SvenRoederer (via GitHub)" <gi...@apache.org>.
SvenRoederer commented on PR #2555:
URL: https://github.com/apache/thrift/pull/2555#issuecomment-1436854911
WOuld love to see this implemented, as currently pypi only offers Thrift 0.16.0 (which has been released some months ago)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [thrift] Jens-G commented on pull request #2555: THRIFT-5546: automate pypi publishing [ci skip]
Posted by "Jens-G (via GitHub)" <gi...@apache.org>.
Jens-G commented on PR #2555:
URL: https://github.com/apache/thrift/pull/2555#issuecomment-1437242626
@jeking3 we're working on 0.18.1 but 0.18.0 is ready. No py changes in 0.18.1 so the choice is yours :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] THRIFT-5546: automate pypi publishing [ci skip] [thrift]
Posted by "bwangelme (via GitHub)" <gi...@apache.org>.
bwangelme commented on PR #2555:
URL: https://github.com/apache/thrift/pull/2555#issuecomment-1774350382
@jeking3
Hello, is there any progress on this issue?
We need a newer python thrift client which is great 0.16.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@thrift.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org