[GitHub] [nifi] markap14 commented on a change in pull request #4804: NIFI-8181 - Added a property to specify whether to allow HTTP2 protoc…

[GitBox <gi...@apache.org>]

markap14 commented on a change in pull request #4804:
URL: https://github.com/apache/nifi/pull/4804#discussion_r569688751



##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
##########
@@ -474,6 +475,16 @@
             .allowableValues("true", "false")
             .build();
 
+    public static final PropertyDescriptor SUPPORT_HTTP2_PROTOCOL = new PropertyDescriptor.Builder()
+            .name("support-http2")
+            .description("Determines whether or not to support the HTTP 2 protocol version.")
+            .displayName("Support HTTP 2")
+            .required(true)
+            .defaultValue("True")
+            .allowableValues("True", "False")

Review comment:
       Debatable on this :) Typically we favor capitalized words in nifi, but with boolean we've tended to use true/false instead of True/False. There's a good mixture throughout the codebase unfortunately. If there is already at least one boolean property in the processor i would say at least try to stay consistent. Otherwise... 🤷‍♂️ 
   Of note, though, there's no need for the Boolean Validator, as there are allowable values.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org