You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/11/03 13:56:36 UTC
[GitHub] [iotdb] suchenglong opened a new pull request, #7900: [IOTDB-4811]Fix snapshot file name error
suchenglong opened a new pull request, #7900:
URL: https://github.com/apache/iotdb/pull/7900
## Description
Fix When data_region is the ratis protocol, the directory of data files generated by snapshot is a file name starting with tmp. The cause is that the snapshot file is not moved when the snapshot is generated.
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are corner cases and error
conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes, inheritance, composition,
design patterns)
- Method organization and design (how the logic is split between methods, parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative name) for every design
(or naming) decision point and compare the alternatives with the designs that you've implemented
(or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in this PR elsewhere
(e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list),
link to that discussion from this PR description and explain what have changed in your final design
compared to your original proposal or the consensus version in the end of the discussion.
If something hasn't changed since the original discussion, you can omit a detailed discussion of
those aspects of the design here, perhaps apart from brief mentioning for the sake of readability
of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] concurrent read
- [ ] concurrent write
- [ ] concurrent read and write
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods.
- [ ] added or updated version, __license__, or notice information
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious
for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold
for code coverage.
- [ ] added integration tests.
- [x] been tested in a test IoTDB cluster.
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items
apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items
from the checklist above are strictly necessary, but it would be very helpful if you at least
self-review the PR. -->
<hr>
##### Key changed/added classes (or packages if there are too many classes) in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] xingtanzjr commented on a diff in pull request #7900: [IOTDB-4811]Fix snapshot file name error
Posted by GitBox <gi...@apache.org>.
xingtanzjr commented on code in PR #7900:
URL: https://github.com/apache/iotdb/pull/7900#discussion_r1016281455
##########
consensus/src/main/java/org/apache/iotdb/consensus/IStateMachine.java:
##########
@@ -69,6 +69,18 @@ default boolean isReadOnly() {
*/
boolean takeSnapshot(File snapshotDir);
+ /**
+ * Take a snapshot of current statemachine. Snapshot.log will be stored under snapshotDir, The
+ * data of the snapshot will be stored under `data folder/snapshot/snapshotId`.
+ *
+ * @param snapshotDir required storage dir
+ * @param snapshotId the id of the snapshot
+ * @return true if snapshot is successfully taken
+ */
+ default boolean takeSnapshot(File snapshotDir, String snapshotId) {
Review Comment:
remove this default implementation and implement this method in all sub-classes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] suchenglong commented on a diff in pull request #7900: [IOTDB-4811]Fix snapshot file name error
Posted by GitBox <gi...@apache.org>.
suchenglong commented on code in PR #7900:
URL: https://github.com/apache/iotdb/pull/7900#discussion_r1016659523
##########
consensus/src/main/java/org/apache/iotdb/consensus/IStateMachine.java:
##########
@@ -69,6 +69,18 @@ default boolean isReadOnly() {
*/
boolean takeSnapshot(File snapshotDir);
+ /**
+ * Take a snapshot of current statemachine. Snapshot.log will be stored under snapshotDir, The
+ * data of the snapshot will be stored under `data folder/snapshot/snapshotId`.
+ *
+ * @param snapshotDir required storage dir
+ * @param snapshotId the id of the snapshot
+ * @return true if snapshot is successfully taken
+ */
+ default boolean takeSnapshot(File snapshotDir, String snapshotId) {
Review Comment:
Other implementation classes do not need to implement the new method, changing the default implementation to call the original method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] xingtanzjr commented on pull request #7900: [IOTDB-4811]Fix snapshot file name error
Posted by GitBox <gi...@apache.org>.
xingtanzjr commented on PR #7900:
URL: https://github.com/apache/iotdb/pull/7900#issuecomment-1308804503
Good job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] xingtanzjr merged pull request #7900: [IOTDB-4811]Fix snapshot file name error
Posted by GitBox <gi...@apache.org>.
xingtanzjr merged PR #7900:
URL: https://github.com/apache/iotdb/pull/7900
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org