You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "xiaocairush (via GitHub)" <gi...@apache.org> on 2023/06/20 13:10:38 UTC

[GitHub] [kafka] xiaocairush opened a new pull request, #13884: MINOR: fix typos for client

xiaocairush opened a new pull request, #13884:
URL: https://github.com/apache/kafka/pull/13884

   *More detailed description of your change,
   
   Fix typos for client
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] xiaocairush commented on pull request #13884: MINOR: fix typos for client

Posted by "xiaocairush (via GitHub)" <gi...@apache.org>.
xiaocairush commented on PR #13884:
URL: https://github.com/apache/kafka/pull/13884#issuecomment-1600037542

   test this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] xiaocairush commented on a diff in pull request #13884: MINOR: fix typos for client

Posted by "xiaocairush (via GitHub)" <gi...@apache.org>.
xiaocairush commented on code in PR #13884:
URL: https://github.com/apache/kafka/pull/13884#discussion_r1244247840


##########
clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java:
##########
@@ -854,7 +854,7 @@ public void shouldThrowOnInvalidDateFormatOrNullTimestamp() {
 
     private void checkExceptionForGetDateTimeMethod(Executable executable) {
         assertTrue(assertThrows(ParseException.class, executable)
-            .getMessage().contains("Unparseable date"));
+            .getMessage().contains("Unparsable date"));

Review Comment:
   fixed!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] showuon commented on a diff in pull request #13884: MINOR: fix typos for client

Posted by "showuon (via GitHub)" <gi...@apache.org>.
showuon commented on code in PR #13884:
URL: https://github.com/apache/kafka/pull/13884#discussion_r1236463301


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetFetcher.java:
##########
@@ -430,7 +430,7 @@ public void onFailure(RuntimeException e) {
      * leaders available. Topic partitions from `timestampsToSearch` that do not have their leader
      * available are added to `partitionsToRetry`
      *
-     * @param timestampsToSearch The mapping from partitions ot the target timestamps
+     * @param timestampsToSearch The mapping from partitions of the target timestamps

Review Comment:
   I think this is `to`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] divijvaidya merged pull request #13884: MINOR: fix typos for client

Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya merged PR #13884:
URL: https://github.com/apache/kafka/pull/13884


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] xiaocairush commented on a diff in pull request #13884: MINOR: fix typos for client

Posted by "xiaocairush (via GitHub)" <gi...@apache.org>.
xiaocairush commented on code in PR #13884:
URL: https://github.com/apache/kafka/pull/13884#discussion_r1236668769


##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/OffsetFetcher.java:
##########
@@ -430,7 +430,7 @@ public void onFailure(RuntimeException e) {
      * leaders available. Topic partitions from `timestampsToSearch` that do not have their leader
      * available are added to `partitionsToRetry`
      *
-     * @param timestampsToSearch The mapping from partitions ot the target timestamps
+     * @param timestampsToSearch The mapping from partitions of the target timestamps

Review Comment:
   Corrected to **"to"**



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] divijvaidya commented on a diff in pull request #13884: MINOR: fix typos for client

Posted by "divijvaidya (via GitHub)" <gi...@apache.org>.
divijvaidya commented on code in PR #13884:
URL: https://github.com/apache/kafka/pull/13884#discussion_r1242669461


##########
clients/src/test/java/org/apache/kafka/common/utils/UtilsTest.java:
##########
@@ -854,7 +854,7 @@ public void shouldThrowOnInvalidDateFormatOrNullTimestamp() {
 
     private void checkExceptionForGetDateTimeMethod(Executable executable) {
         assertTrue(assertThrows(ParseException.class, executable)
-            .getMessage().contains("Unparseable date"));
+            .getMessage().contains("Unparsable date"));

Review Comment:
   we have some test failures associated with this: https://ci-builds.apache.org/job/Kafka/job/kafka-pr/job/PR-13884/3/testReport/junit/org.apache.kafka.common.utils/UtilsTest/Build___JDK_11_and_Scala_2_13___shouldThrowOnInvalidDateFormatOrNullTimestamp__/ 
   
   Please fix the source code along with the test validation.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org