[GitHub] [fineract] marta-jankovics commented on issue #606: remove Apache BVal @NotEmpty annotation use

[GitBox <gi...@apache.org>]

marta-jankovics commented on issue #606: remove Apache BVal @NotEmpty annotation use
URL: https://github.com/apache/fineract/pull/606#issuecomment-508757755
 
 
   > @marta-jankovics - just FYI, we are removing the notempty annotation as indicated above. This should not affect functionality of interoperability layer. The NotNull checks should take care of any edge cases.
   > 
   > @vorburger - could you please add a NotNull annotation on the InteropIdentifierRequestData constructor for the accountId field:
   > 
   > `public InteropIdentifierRequestData(@NotNull InteropIdentifierType idType, @NotNull String idValue, String subIdOrType, String accountId) {	public InteropIdentifierRequestData(@NotNull InteropIdentifierType idType, @NotNull String idValue, String subIdOrType, String accountId) `
   > 
   > should become:
   > 
   > `public InteropIdentifierRequestData(@NotNull InteropIdentifierType idType, @NotNull String idValue, String subIdOrType, String accountId) {	public InteropIdentifierRequestData(@NotNull InteropIdentifierType idType, @NotNull String idValue, String subIdOrType, @NotNull String accountId) `
   > 
   > After that, it looks good to me and I can merge (or you can go ahead and merge).
   
   @conradsp Hi Conrad, thank you for your notice! Without checking the concrete code fragment you are going to modify:
   @NotEmpty
   "The annotated element must not be {@code null} nor empty."
   @NotNull 
   "The annotated element must not be {@code null}"
   so to me it seems that if you replace @NotEmpty with @NotNull you would affect the functionality.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services