You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/08/19 09:17:11 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #5856: [AIRFLOW-5250] fix all dmypy error for gcp hooks

mik-laj commented on a change in pull request #5856: [AIRFLOW-5250] fix all dmypy error for gcp hooks
URL: https://github.com/apache/airflow/pull/5856#discussion_r315112308
 
 

 ##########
 File path: airflow/contrib/hooks/gcp_cloud_build_hook.py
 ##########
 @@ -48,7 +48,7 @@ class CloudBuildHook(GoogleCloudBaseHook):
     :type delegate_to: str
     """
 
-    _conn = None
+    _conn = None  # type: Optional[Resource]
 
 Review comment:
   This is not a proper type. Google API Client (discovery based) generate types at runtime. I think, we should use `Any` or introduce generated prototype. I prefer `Any`. The Resource class doesn't have public method. WDYT?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services