You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@plc4x.apache.org by GitBox <gi...@apache.org> on 2020/05/25 09:22:13 UTC
[GitHub] [plc4x] patrickse opened a new pull request #158: Updated Eclipse Milo to 0.3.7
patrickse opened a new pull request #158:
URL: https://github.com/apache/plc4x/pull/158
Eclipse Milo 0.3.7 supports relaxed nonce validation when not using protected credentials. It's needed to talk to development PLC from Schneider Electric.
https://github.com/eclipse/milo/commit/35ee06ea87676db9fdf4caf748b9265c40d1c841
Signed-off-by: Patrick Sernetz <ps...@cad-schroer.de>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] JulianFeinauer commented on pull request #158: Updated Eclipse Milo to 0.3.7
Posted by GitBox <gi...@apache.org>.
JulianFeinauer commented on pull request #158:
URL: https://github.com/apache/plc4x/pull/158#issuecomment-633479750
Good question, indeed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] nalim2 edited a comment on pull request #158: Updated Eclipse Milo to 0.3.7
Posted by GitBox <gi...@apache.org>.
nalim2 edited a comment on pull request #158:
URL: https://github.com/apache/plc4x/pull/158#issuecomment-633525795
Yeah i think to include there a Sample Server should be a good idea. I would first just integrate a Milo example server and would transfere the ManualTest class to an integration test or what you mean by the TestContainers Project?
If there would be an alternativ server it would be better to get possible specification problems
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] patrickse commented on pull request #158: Updated Eclipse Milo to 0.3.7
Posted by GitBox <gi...@apache.org>.
patrickse commented on pull request #158:
URL: https://github.com/apache/plc4x/pull/158#issuecomment-633479410
I am not aware of any integration test. We've changed the dependency and deployd it to our platform. It looks ok for now. How could I implement an integration test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] JulianFeinauer edited a comment on pull request #158: Updated Eclipse Milo to 0.3.7
Posted by GitBox <gi...@apache.org>.
JulianFeinauer edited a comment on pull request #158:
URL: https://github.com/apache/plc4x/pull/158#issuecomment-633479750
Good question, indeed. But good to know that it works for you. @nalim2 we should definetly have a look there. Probably we could start an OPC Server and start a Client and just do some sending. Probably even using the awesome TestContainers Project?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] nalim2 commented on pull request #158: Updated Eclipse Milo to 0.3.7
Posted by GitBox <gi...@apache.org>.
nalim2 commented on pull request #158:
URL: https://github.com/apache/plc4x/pull/158#issuecomment-633525795
Yeah i think to include there a Sample Server should be a good idea. I would first just integrate a Milo example server and would transfere the ManualTest class to an integration test or what you mean by the TestContainers Project?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] nalim2 merged pull request #158: Updated Eclipse Milo to 0.3.7
Posted by GitBox <gi...@apache.org>.
nalim2 merged pull request #158:
URL: https://github.com/apache/plc4x/pull/158
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] nalim2 commented on pull request #158: Updated Eclipse Milo to 0.3.7
Posted by GitBox <gi...@apache.org>.
nalim2 commented on pull request #158:
URL: https://github.com/apache/plc4x/pull/158#issuecomment-633527174
But just the updated versions lgtm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [plc4x] JulianFeinauer commented on pull request #158: Updated Eclipse Milo to 0.3.7
Posted by GitBox <gi...@apache.org>.
JulianFeinauer commented on pull request #158:
URL: https://github.com/apache/plc4x/pull/158#issuecomment-633477367
Thanks @patrickse ! Do we have integration tests for milo or did you test the code already?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org