You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jena.apache.org by GitBox <gi...@apache.org> on 2020/01/10 05:20:55 UTC
[GitHub] [jena] DamienFontaine opened a new pull request #669:
MaxBasicQueries
DamienFontaine opened a new pull request #669: MaxBasicQueries
URL: https://github.com/apache/jena/pull/669
Add a new parameter text:maxBasicQueries used by the surround query parser.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [jena] afs edited a comment on issue #669: MaxBasicQueries
Posted by GitBox <gi...@apache.org>.
afs edited a comment on issue #669: MaxBasicQueries
URL: https://github.com/apache/jena/pull/669#issuecomment-593541482
JENA-1837
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs edited a comment on issue #669: JENA-1837:
MaxBasicQueries
Posted by GitBox <gi...@apache.org>.
afs edited a comment on issue #669: JENA-1837: MaxBasicQueries
URL: https://github.com/apache/jena/pull/669#issuecomment-581162427
@osma : when convenient, could you review this please?
I tried to add you as a reviewer but your GH name wasn't an option. One possibility is that your account isn't linked to the Apache Github organisation : https://gitbox.apache.org/setup/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] osma commented on issue #669: MaxBasicQueries
Posted by GitBox <gi...@apache.org>.
osma commented on issue #669: MaxBasicQueries
URL: https://github.com/apache/jena/pull/669#issuecomment-581984607
I'm not very familiar with `SurroundQueryParser` as I haven't used it myself, but I take it that making it possible to set the `maxBasicQueries` parameter is important to some class of users. So I will just make a few general comments:
1. I think we need a corresponding Jira issue on issues.apache.org to keep track of this enhancement and the release it appears in - could you open one @DamienFontaine please?
2. You should add unit tests that exercise the new sections of code. At a minimum, the positive case should be tested, i.e. setting maxBasicQueries to some non-default value and verifying that the value actually gets passed to the BasicQueryFactory.
3. The new parameter should be mentioned in the [jena-text documentation](https://jena.apache.org/documentation/query/text-query.html), probably somewhere within the section on alternate query parsers that mentions SurroundQueryParser.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] osma commented on issue #669: MaxBasicQueries
Posted by GitBox <gi...@apache.org>.
osma commented on issue #669: MaxBasicQueries
URL: https://github.com/apache/jena/pull/669#issuecomment-581454597
@afs Sure thing, will review soon. Just setting up the account linking, thanks for reminding.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] DamienFontaine commented on issue #669: MaxBasicQueries
Posted by GitBox <gi...@apache.org>.
DamienFontaine commented on issue #669: MaxBasicQueries
URL: https://github.com/apache/jena/pull/669#issuecomment-574106572
To avoid excessively long execution times, MaxBasicQueries limits the generation of queries to 1024. In some cases, this limit is too low.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [jena] afs commented on issue #669: MaxBasicQueries
Posted by GitBox <gi...@apache.org>.
afs commented on issue #669: MaxBasicQueries
URL: https://github.com/apache/jena/pull/669#issuecomment-593541482
JENA-1837.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on issue #669: MaxBasicQueries
Posted by GitBox <gi...@apache.org>.
afs commented on issue #669: MaxBasicQueries
URL: https://github.com/apache/jena/pull/669#issuecomment-581162427
@osma : when convenient, could you review this please?
I tried to add you as a reviewer but your GH name wasn't an option. On epossibility is that your account isn't linked to the Apache Github organisation : https://gitbox.apache.org/setup/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs edited a comment on issue #669: MaxBasicQueries
Posted by GitBox <gi...@apache.org>.
afs edited a comment on issue #669: MaxBasicQueries
URL: https://github.com/apache/jena/pull/669#issuecomment-593541482
[JENA-1837](https://issues.apache.org/jira/browse/JENA-1837)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] rvesse commented on issue #669: MaxBasicQueries
Posted by GitBox <gi...@apache.org>.
rvesse commented on issue #669: MaxBasicQueries
URL: https://github.com/apache/jena/pull/669#issuecomment-574088811
I presume this is fixing some kind of potential performance pitfall? Some explanation of why this change is necessary would be helpful to understand the context of this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services