You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2019/01/07 15:30:09 UTC

[GitHub] apiri commented on a change in pull request #465: MINIFICPP-700: Add MSI Support via CPACK

apiri commented on a change in pull request #465: MINIFICPP-700: Add MSI Support via CPACK
URL: https://github.com/apache/nifi-minifi-cpp/pull/465#discussion_r245314405
 
 

 ##########
 File path: msi/LICENSE.txt
 ##########
 @@ -0,0 +1,1633 @@
+
 
 Review comment:
   Not pertinent to this PR specifically, but this did jog the mind a bit.  While our license is correct for the source for all the thirdparty libs we use, this is not necessarily true for the resultant binary as we can select which modules are enabled.  In full correctness, I suspect we likely need the LICENSE to reflect which modules were enabled to avoid being unnecessarily onerous with the binary that is made.  If that thinking is correct, I can file an issue to address this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services