You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org> on 2010/03/22 22:25:27 UTC

[jira] Created: (MYFACES-2618) Don't warn if there is no submitted value in the current request for every EditableValueHolder

Don't warn if there is no submitted value in the current request for every EditableValueHolder
----------------------------------------------------------------------------------------------

                 Key: MYFACES-2618
                 URL: https://issues.apache.org/jira/browse/MYFACES-2618
             Project: MyFaces Core
          Issue Type: Task
          Components: JSR-314
    Affects Versions: 2.0.0-beta-2
            Reporter: Jakob Korherr
            Assignee: Jakob Korherr
            Priority: Minor


Take a look at HtmlRendererUtils.decodeUIInput(): There we do a check for paramMap.containsKey(clientId) and if this returns false (meaning that there is no submitted value for the given component in the request parameter map) we add a warning message to the log.

I think we should get rid of this warning, because as a reason of AJAX it is on my opinion normal to not submit all values of a form in every request. Furthermore it has no impact on the lifecycle, because if the submitted value is null it just isn't processed any further.

See also the related thread on the mailing list: http://www.mail-archive.com/users@myfaces.apache.org/msg55238.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MYFACES-2618) Don't warn if there is no submitted value in the current request for every EditableValueHolder

Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850845#action_12850845 ] 

Jakob Korherr commented on MYFACES-2618:
----------------------------------------

Hi Martin,

Ooh, ok - frankly, I did not think of that. So I just asked the user, who brought that up on the mailing list, to describe his scenario in more detail here or even to add a small test webapp. I hope this will help us figure out what to do.

Regards,
Jakob

> Don't warn if there is no submitted value in the current request for every EditableValueHolder
> ----------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-2618
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2618
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>    Affects Versions: 2.0.0-beta-2
>            Reporter: Jakob Korherr
>            Assignee: Jakob Korherr
>            Priority: Minor
>         Attachments: MYFACES-2618.patch
>
>
> Take a look at HtmlRendererUtils.decodeUIInput(): There we do a check for paramMap.containsKey(clientId) and if this returns false (meaning that there is no submitted value for the given component in the request parameter map) we add a warning message to the log.
> I think we should get rid of this warning, because as a reason of AJAX it is on my opinion normal to not submit all values of a form in every request. Furthermore it has no impact on the lifecycle, because if the submitted value is null it just isn't processed any further.
> See also the related thread on the mailing list: http://www.mail-archive.com/users@myfaces.apache.org/msg55238.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MYFACES-2618) Don't warn if there is no submitted value in the current request for every EditableValueHolder

Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909278#action_12909278 ] 

Jakob Korherr commented on MYFACES-2618:
----------------------------------------

Yes you could do that!

Nope, it uses commons-logging.

Usually the name of the class, which logs the entry.

> Don't warn if there is no submitted value in the current request for every EditableValueHolder
> ----------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-2618
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2618
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>    Affects Versions: 2.0.0-beta-2
>            Reporter: Jakob Korherr
>            Assignee: Jakob Korherr
>            Priority: Minor
>         Attachments: MYFACES-2618.patch
>
>
> Take a look at HtmlRendererUtils.decodeUIInput(): There we do a check for paramMap.containsKey(clientId) and if this returns false (meaning that there is no submitted value for the given component in the request parameter map) we add a warning message to the log.
> I think we should get rid of this warning, because as a reason of AJAX it is on my opinion normal to not submit all values of a form in every request. Furthermore it has no impact on the lifecycle, because if the submitted value is null it just isn't processed any further.
> See also the related thread on the mailing list: http://www.mail-archive.com/users@myfaces.apache.org/msg55238.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (MYFACES-2618) Don't warn if there is no submitted value in the current request for every EditableValueHolder

Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/MYFACES-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jakob Korherr updated MYFACES-2618:
-----------------------------------

    Status: Patch Available  (was: Open)

> Don't warn if there is no submitted value in the current request for every EditableValueHolder
> ----------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-2618
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2618
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>    Affects Versions: 2.0.0-beta-2
>            Reporter: Jakob Korherr
>            Assignee: Jakob Korherr
>            Priority: Minor
>         Attachments: MYFACES-2618.patch
>
>
> Take a look at HtmlRendererUtils.decodeUIInput(): There we do a check for paramMap.containsKey(clientId) and if this returns false (meaning that there is no submitted value for the given component in the request parameter map) we add a warning message to the log.
> I think we should get rid of this warning, because as a reason of AJAX it is on my opinion normal to not submit all values of a form in every request. Furthermore it has no impact on the lifecycle, because if the submitted value is null it just isn't processed any further.
> See also the related thread on the mailing list: http://www.mail-archive.com/users@myfaces.apache.org/msg55238.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MYFACES-2618) Don't warn if there is no submitted value in the current request for every EditableValueHolder

Posted by "Dave (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866186#action_12866186 ] 

Dave commented on MYFACES-2618:
-------------------------------

could the priority be raised?  it is urgent for ajax.

> Don't warn if there is no submitted value in the current request for every EditableValueHolder
> ----------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-2618
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2618
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>    Affects Versions: 2.0.0-beta-2
>            Reporter: Jakob Korherr
>            Assignee: Jakob Korherr
>            Priority: Minor
>         Attachments: MYFACES-2618.patch
>
>
> Take a look at HtmlRendererUtils.decodeUIInput(): There we do a check for paramMap.containsKey(clientId) and if this returns false (meaning that there is no submitted value for the given component in the request parameter map) we add a warning message to the log.
> I think we should get rid of this warning, because as a reason of AJAX it is on my opinion normal to not submit all values of a form in every request. Furthermore it has no impact on the lifecycle, because if the submitted value is null it just isn't processed any further.
> See also the related thread on the mailing list: http://www.mail-archive.com/users@myfaces.apache.org/msg55238.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MYFACES-2618) Don't warn if there is no submitted value in the current request for every EditableValueHolder

Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864955#action_12864955 ] 

Leonardo Uribe commented on MYFACES-2618:
-----------------------------------------

This could be evidence that something is wrong in UIViewRoot.processDecodes. It is necessary to check is partial ajax lifecycle is working as expected.

> Don't warn if there is no submitted value in the current request for every EditableValueHolder
> ----------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-2618
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2618
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>    Affects Versions: 2.0.0-beta-2
>            Reporter: Jakob Korherr
>            Assignee: Jakob Korherr
>            Priority: Minor
>         Attachments: MYFACES-2618.patch
>
>
> Take a look at HtmlRendererUtils.decodeUIInput(): There we do a check for paramMap.containsKey(clientId) and if this returns false (meaning that there is no submitted value for the given component in the request parameter map) we add a warning message to the log.
> I think we should get rid of this warning, because as a reason of AJAX it is on my opinion normal to not submit all values of a form in every request. Furthermore it has no impact on the lifecycle, because if the submitted value is null it just isn't processed any further.
> See also the related thread on the mailing list: http://www.mail-archive.com/users@myfaces.apache.org/msg55238.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MYFACES-2618) Don't warn if there is no submitted value in the current request for every EditableValueHolder

Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12866578#action_12866578 ] 

Jakob Korherr commented on MYFACES-2618:
----------------------------------------

If you use the JSF 2.0 built-in AJAX mechanism this should not happen, because this mechanism only processes necessary components. So I guess you're using your own AJAX mechanism, right?

> Don't warn if there is no submitted value in the current request for every EditableValueHolder
> ----------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-2618
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2618
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>    Affects Versions: 2.0.0-beta-2
>            Reporter: Jakob Korherr
>            Assignee: Jakob Korherr
>            Priority: Minor
>         Attachments: MYFACES-2618.patch
>
>
> Take a look at HtmlRendererUtils.decodeUIInput(): There we do a check for paramMap.containsKey(clientId) and if this returns false (meaning that there is no submitted value for the given component in the request parameter map) we add a warning message to the log.
> I think we should get rid of this warning, because as a reason of AJAX it is on my opinion normal to not submit all values of a form in every request. Furthermore it has no impact on the lifecycle, because if the submitted value is null it just isn't processed any further.
> See also the related thread on the mailing list: http://www.mail-archive.com/users@myfaces.apache.org/msg55238.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MYFACES-2618) Don't warn if there is no submitted value in the current request for every EditableValueHolder

Posted by "Martin Marinschek (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848656#action_12848656 ] 

Martin Marinschek commented on MYFACES-2618:
--------------------------------------------

Hi Jakob,

I am not sure, I think I might object ;)

Why that warning is invented is easily explained: users often forget that the rendered attribute needs to be bound to a bean in scope session or conversation.

And if they forget this, the rendered attribute might have toggled (to true), and suddenly we try to decode something for which no submitted value is there. To give the user at least some information that there is a problem, we log that warning.

Now, for the AJAX case: if nothing is submitted, why would you run the decoding for this field? That sounds a bit strange to me. You might decide to execute only some of the fields, but then you would also submit these fields - a split between submitting some and decoding some others is nothing which I would see as being useful.

In short: I need more information to decide that I would object, but I think I will.

best regards,

Martin

> Don't warn if there is no submitted value in the current request for every EditableValueHolder
> ----------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-2618
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2618
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>    Affects Versions: 2.0.0-beta-2
>            Reporter: Jakob Korherr
>            Assignee: Jakob Korherr
>            Priority: Minor
>         Attachments: MYFACES-2618.patch
>
>
> Take a look at HtmlRendererUtils.decodeUIInput(): There we do a check for paramMap.containsKey(clientId) and if this returns false (meaning that there is no submitted value for the given component in the request parameter map) we add a warning message to the log.
> I think we should get rid of this warning, because as a reason of AJAX it is on my opinion normal to not submit all values of a form in every request. Furthermore it has no impact on the lifecycle, because if the submitted value is null it just isn't processed any further.
> See also the related thread on the mailing list: http://www.mail-archive.com/users@myfaces.apache.org/msg55238.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MYFACES-2618) Don't warn if there is no submitted value in the current request for every EditableValueHolder

Posted by "Dave (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12850929#action_12850929 ] 

Dave commented on MYFACES-2618:
-------------------------------

This is our use case.

We made an ajax-enabled JSF component. When user changes select value of the component, an ajax request with the new select value will be sent to the server side.  We use the component decode() method to process the ajax request.

The ajax request parameters:

  var formSubmitParam = select.form.id + "_SUBMIT";   // why need this?
  var url = serverURL +	"&ajax=1&sid=" + Math.random() +
    "&" + formSubmitParam + "=1" + 
    "&" + clientId + "=" + selectValue;

the serverURL contains view_state for restoring view. If we do not add the formSubmitParam, the component decode() method will not be called.   The url above works well for processing ajax request in the decode method. But we got the warning. The warning is not prefered. If there is a way to keep it silent, it would be great, for example, adding a parameter.




> Don't warn if there is no submitted value in the current request for every EditableValueHolder
> ----------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-2618
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2618
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>    Affects Versions: 2.0.0-beta-2
>            Reporter: Jakob Korherr
>            Assignee: Jakob Korherr
>            Priority: Minor
>         Attachments: MYFACES-2618.patch
>
>
> Take a look at HtmlRendererUtils.decodeUIInput(): There we do a check for paramMap.containsKey(clientId) and if this returns false (meaning that there is no submitted value for the given component in the request parameter map) we add a warning message to the log.
> I think we should get rid of this warning, because as a reason of AJAX it is on my opinion normal to not submit all values of a form in every request. Furthermore it has no impact on the lifecycle, because if the submitted value is null it just isn't processed any further.
> See also the related thread on the mailing list: http://www.mail-archive.com/users@myfaces.apache.org/msg55238.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MYFACES-2618) Don't warn if there is no submitted value in the current request for every EditableValueHolder

Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12867142#action_12867142 ] 

Jakob Korherr commented on MYFACES-2618:
----------------------------------------

Oh ok.. At first you need to use a JSF 2.0 implementation (like MyFaces 2.0 or Mojarra 2.0) and then you need Tomahawk20, which is not out yet.

I think it is the best option here to add a web.xml config param to say that you are using a custom built AJAX mechansim that does not submit all values. Setting this to true would omit the warning in the log.

> Don't warn if there is no submitted value in the current request for every EditableValueHolder
> ----------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-2618
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2618
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>    Affects Versions: 2.0.0-beta-2
>            Reporter: Jakob Korherr
>            Assignee: Jakob Korherr
>            Priority: Minor
>         Attachments: MYFACES-2618.patch
>
>
> Take a look at HtmlRendererUtils.decodeUIInput(): There we do a check for paramMap.containsKey(clientId) and if this returns false (meaning that there is no submitted value for the given component in the request parameter map) we add a warning message to the log.
> I think we should get rid of this warning, because as a reason of AJAX it is on my opinion normal to not submit all values of a form in every request. Furthermore it has no impact on the lifecycle, because if the submitted value is null it just isn't processed any further.
> See also the related thread on the mailing list: http://www.mail-archive.com/users@myfaces.apache.org/msg55238.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MYFACES-2618) Don't warn if there is no submitted value in the current request for every EditableValueHolder

Posted by "Jakob Korherr (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12848358#action_12848358 ] 

Jakob Korherr commented on MYFACES-2618:
----------------------------------------

spec javadoc of UIInput.validate(): "Retrieve the submitted value with getSubmittedValue(). If this returns null, exit without further processing. (This indicates that no value was submitted for this component.)"

Nothing about a warning mentioned here...

> Don't warn if there is no submitted value in the current request for every EditableValueHolder
> ----------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-2618
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2618
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>    Affects Versions: 2.0.0-beta-2
>            Reporter: Jakob Korherr
>            Assignee: Jakob Korherr
>            Priority: Minor
>
> Take a look at HtmlRendererUtils.decodeUIInput(): There we do a check for paramMap.containsKey(clientId) and if this returns false (meaning that there is no submitted value for the given component in the request parameter map) we add a warning message to the log.
> I think we should get rid of this warning, because as a reason of AJAX it is on my opinion normal to not submit all values of a form in every request. Furthermore it has no impact on the lifecycle, because if the submitted value is null it just isn't processed any further.
> See also the related thread on the mailing list: http://www.mail-archive.com/users@myfaces.apache.org/msg55238.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MYFACES-2618) Don't warn if there is no submitted value in the current request for every EditableValueHolder

Posted by "Dave (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864255#action_12864255 ] 

Dave commented on MYFACES-2618:
-------------------------------

In our case, one such warning is about 2.5K. The component path is very long. 
We redirect warning to a log file. so the warnings will explode disk space after running for a few days. We hope that there is a parameter in faces-config.xml for keeping the warning silent.

>>>-------------
Now, for the AJAX case: if nothing is submitted, why would you run the decoding for this field? That sounds a bit strange to me. You might decide to execute only some of the fields, but then you would also submit these fields - a split between submitting some and decoding some others is nothing which I would see as being useful.
>>>----------

For ajax, we send ajax request with parameters(name/value pairs) for submitted values. For submitted values:

clientId_1=value1
clientId_2=value2

If the form has clientId_3, but no value is submitted for clientId_3, then there will be no parameter for clientId_3.  The decode() method should not be called for clientId_3.  Is it called?  If it is called but no submitted value, the decode method should ignore it without any warning.






> Don't warn if there is no submitted value in the current request for every EditableValueHolder
> ----------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-2618
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2618
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>    Affects Versions: 2.0.0-beta-2
>            Reporter: Jakob Korherr
>            Assignee: Jakob Korherr
>            Priority: Minor
>         Attachments: MYFACES-2618.patch
>
>
> Take a look at HtmlRendererUtils.decodeUIInput(): There we do a check for paramMap.containsKey(clientId) and if this returns false (meaning that there is no submitted value for the given component in the request parameter map) we add a warning message to the log.
> I think we should get rid of this warning, because as a reason of AJAX it is on my opinion normal to not submit all values of a form in every request. Furthermore it has no impact on the lifecycle, because if the submitted value is null it just isn't processed any further.
> See also the related thread on the mailing list: http://www.mail-archive.com/users@myfaces.apache.org/msg55238.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MYFACES-2618) Don't warn if there is no submitted value in the current request for every EditableValueHolder

Posted by "Dave (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12867140#action_12867140 ] 

Dave commented on MYFACES-2618:
-------------------------------

Yes. we use our own way, adding "ajax=1" parameter to request URL. Is there a document for using JSF 2.0 ajax?

> Don't warn if there is no submitted value in the current request for every EditableValueHolder
> ----------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-2618
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2618
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>    Affects Versions: 2.0.0-beta-2
>            Reporter: Jakob Korherr
>            Assignee: Jakob Korherr
>            Priority: Minor
>         Attachments: MYFACES-2618.patch
>
>
> Take a look at HtmlRendererUtils.decodeUIInput(): There we do a check for paramMap.containsKey(clientId) and if this returns false (meaning that there is no submitted value for the given component in the request parameter map) we add a warning message to the log.
> I think we should get rid of this warning, because as a reason of AJAX it is on my opinion normal to not submit all values of a form in every request. Furthermore it has no impact on the lifecycle, because if the submitted value is null it just isn't processed any further.
> See also the related thread on the mailing list: http://www.mail-archive.com/users@myfaces.apache.org/msg55238.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (MYFACES-2618) Don't warn if there is no submitted value in the current request for every EditableValueHolder

Posted by "Dave (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12908397#action_12908397 ] 

Dave commented on MYFACES-2618:
-------------------------------

can I set log level to error to hide warn message?  Does tomahawk use log4j? what is the logger name? thanks!

> Don't warn if there is no submitted value in the current request for every EditableValueHolder
> ----------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-2618
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2618
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>    Affects Versions: 2.0.0-beta-2
>            Reporter: Jakob Korherr
>            Assignee: Jakob Korherr
>            Priority: Minor
>         Attachments: MYFACES-2618.patch
>
>
> Take a look at HtmlRendererUtils.decodeUIInput(): There we do a check for paramMap.containsKey(clientId) and if this returns false (meaning that there is no submitted value for the given component in the request parameter map) we add a warning message to the log.
> I think we should get rid of this warning, because as a reason of AJAX it is on my opinion normal to not submit all values of a form in every request. Furthermore it has no impact on the lifecycle, because if the submitted value is null it just isn't processed any further.
> See also the related thread on the mailing list: http://www.mail-archive.com/users@myfaces.apache.org/msg55238.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (MYFACES-2618) Don't warn if there is no submitted value in the current request for every EditableValueHolder

Posted by "Dave (JIRA)" <de...@myfaces.apache.org>.
    [ https://issues.apache.org/jira/browse/MYFACES-2618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12867140#action_12867140 ] 

Dave edited comment on MYFACES-2618 at 5/13/10 10:13 AM:
---------------------------------------------------------

Yes. we use our own way, adding "ajax=1" parameter to request URL. Is there a document for using JSF 2.0 ajax?  We are using Sun jsf ri 1.2.12 and Tomahawk12 1.1.9. Do we need to upgrade Tomahawk in order to use JSF 2.0? Thanks!

      was (Author: javaone9):
    Yes. we use our own way, adding "ajax=1" parameter to request URL. Is there a document for using JSF 2.0 ajax?
  
> Don't warn if there is no submitted value in the current request for every EditableValueHolder
> ----------------------------------------------------------------------------------------------
>
>                 Key: MYFACES-2618
>                 URL: https://issues.apache.org/jira/browse/MYFACES-2618
>             Project: MyFaces Core
>          Issue Type: Task
>          Components: JSR-314
>    Affects Versions: 2.0.0-beta-2
>            Reporter: Jakob Korherr
>            Assignee: Jakob Korherr
>            Priority: Minor
>         Attachments: MYFACES-2618.patch
>
>
> Take a look at HtmlRendererUtils.decodeUIInput(): There we do a check for paramMap.containsKey(clientId) and if this returns false (meaning that there is no submitted value for the given component in the request parameter map) we add a warning message to the log.
> I think we should get rid of this warning, because as a reason of AJAX it is on my opinion normal to not submit all values of a form in every request. Furthermore it has no impact on the lifecycle, because if the submitted value is null it just isn't processed any further.
> See also the related thread on the mailing list: http://www.mail-archive.com/users@myfaces.apache.org/msg55238.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.