You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "liyubin117 (via GitHub)" <gi...@apache.org> on 2024/11/21 03:16:46 UTC
[PR] [doc] Fix `delete` syntax doc [paimon]
liyubin117 opened a new pull request, #4560:
URL: https://github.com/apache/paimon/pull/4560
### Purpose
As https://github.com/apache/paimon/pull/4273 merged, we need to update related docs.
### Tests
### API and Format
### Documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [doc] Fix `delete` syntax doc [paimon]
Posted by "liyubin117 (via GitHub)" <gi...@apache.org>.
liyubin117 commented on PR #4560:
URL: https://github.com/apache/paimon/pull/4560#issuecomment-2489992584
@JingsongLi I found the current `delete` syntax doc was confusing users, CI passed, PTAL, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [doc] Fix `delete` syntax doc [paimon]
Posted by "liyubin117 (via GitHub)" <gi...@apache.org>.
liyubin117 commented on code in PR #4560:
URL: https://github.com/apache/paimon/pull/4560#discussion_r1851412778
##########
docs/layouts/shortcodes/generated/core_configuration.html:
##########
@@ -561,7 +561,7 @@
<td><h5>partial-update.remove-record-on-sequence-group</h5></td>
<td style="word-wrap: break-word;">(none)</td>
<td>String</td>
- <td>Whether to remove the whole row in partial-update engine when -D records of specified sequence group are received.</td>
+ <td>When -D records of the given sequence group are received, remove the whole row.</td>
Review Comment:
done :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [doc] Fix `delete` syntax doc [paimon]
Posted by "wwj6591812 (via GitHub)" <gi...@apache.org>.
wwj6591812 commented on PR #4560:
URL: https://github.com/apache/paimon/pull/4560#issuecomment-2490307012
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [doc] Fix `delete` syntax doc [paimon]
Posted by "liyubin117 (via GitHub)" <gi...@apache.org>.
liyubin117 commented on code in PR #4560:
URL: https://github.com/apache/paimon/pull/4560#discussion_r1851412778
##########
docs/layouts/shortcodes/generated/core_configuration.html:
##########
@@ -561,7 +561,7 @@
<td><h5>partial-update.remove-record-on-sequence-group</h5></td>
<td style="word-wrap: break-word;">(none)</td>
<td>String</td>
- <td>Whether to remove the whole row in partial-update engine when -D records of specified sequence group are received.</td>
+ <td>When -D records of the given sequence group are received, remove the whole row.</td>
Review Comment:
Thanks for your reminds, done :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [doc] Improve doc for `delete` syntax [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi merged PR #4560:
URL: https://github.com/apache/paimon/pull/4560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [doc] Fix `delete` syntax doc [paimon]
Posted by "JingsongLi (via GitHub)" <gi...@apache.org>.
JingsongLi commented on code in PR #4560:
URL: https://github.com/apache/paimon/pull/4560#discussion_r1851272385
##########
docs/layouts/shortcodes/generated/core_configuration.html:
##########
@@ -561,7 +561,7 @@
<td><h5>partial-update.remove-record-on-sequence-group</h5></td>
<td style="word-wrap: break-word;">(none)</td>
<td>String</td>
- <td>Whether to remove the whole row in partial-update engine when -D records of specified sequence group are received.</td>
+ <td>When -D records of the given sequence group are received, remove the whole row.</td>
Review Comment:
Please update CoreOptions class too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org