You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org> on 2024/07/11 14:24:04 UTC

[Impala-ASF-CR] IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Noemi Pap-Takacs has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21578


Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write
......................................................................

IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Impala can only modify an Iceberg table via 'merge-on-read'.
The 'iceberg_enable_merge_on_read_operations' backend flag makes
it possible to execute 'merge-on-read' operations (DELETE, UPDATE, MERGE)
even if the table property is 'copy-on-write'.

Testing:
 - custom cluster test

Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
---
M be/src/common/global-flags.cc
M be/src/util/backend-gflag-util.cc
M common/thrift/BackendGflags.thrift
M fe/src/main/java/org/apache/impala/analysis/IcebergDeleteImpl.java
M fe/src/main/java/org/apache/impala/analysis/IcebergModifyImpl.java
M fe/src/main/java/org/apache/impala/analysis/IcebergUpdateImpl.java
M fe/src/main/java/org/apache/impala/service/BackendConfig.java
A tests/custom_cluster/test_iceberg_enable_merge_on_read.py
8 files changed, 109 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/21578/1
-- 
To view, visit http://gerrit.cloudera.org:8080/21578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
Gerrit-Change-Number: 21578
Gerrit-PatchSet: 1
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>

[Impala-ASF-CR] IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21578 )

Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write
......................................................................


Patch Set 9: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/21578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
Gerrit-Change-Number: 21578
Gerrit-PatchSet: 9
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jul 2024 14:13:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21578 )

Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write
......................................................................


Patch Set 3:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/16539/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/21578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
Gerrit-Change-Number: 21578
Gerrit-PatchSet: 3
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jul 2024 15:38:21 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/21578 )

Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write
......................................................................

IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Impala can only modify an Iceberg table via 'merge-on-read'. The
'iceberg_always allow_merge_on_read_operations' backend flag makes it
possible to execute 'merge-on-read' operations (DELETE, UPDATE, MERGE)
even if the table property is 'copy-on-write'.

Testing:
 - custom cluster test

Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
---
M be/src/common/global-flags.cc
M be/src/util/backend-gflag-util.cc
M common/thrift/BackendGflags.thrift
M fe/src/main/java/org/apache/impala/analysis/IcebergDeleteImpl.java
M fe/src/main/java/org/apache/impala/analysis/IcebergModifyImpl.java
M fe/src/main/java/org/apache/impala/analysis/IcebergUpdateImpl.java
M fe/src/main/java/org/apache/impala/service/BackendConfig.java
A tests/custom_cluster/test_iceberg_always_allow_merge_on_read.py
8 files changed, 113 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/21578/3
-- 
To view, visit http://gerrit.cloudera.org:8080/21578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
Gerrit-Change-Number: 21578
Gerrit-PatchSet: 3
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21578 )

Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
Gerrit-Change-Number: 21578
Gerrit-PatchSet: 4
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jul 2024 15:15:17 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21578 )

Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write
......................................................................


Patch Set 5: -Code-Review


-- 
To view, visit http://gerrit.cloudera.org:8080/21578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
Gerrit-Change-Number: 21578
Gerrit-PatchSet: 5
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Jul 2024 12:22:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21578 )

Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10805/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/21578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
Gerrit-Change-Number: 21578
Gerrit-PatchSet: 4
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jul 2024 15:15:18 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21578 )

Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21578/2/fe/src/main/java/org/apache/impala/analysis/IcebergModifyImpl.java
File fe/src/main/java/org/apache/impala/analysis/IcebergModifyImpl.java:

http://gerrit.cloudera.org:8080/#/c/21578/2/fe/src/main/java/org/apache/impala/analysis/IcebergModifyImpl.java@80
PS2, Line 80: getModifyMode
Nit: could extract it into a variable, also used on L75.



-- 
To view, visit http://gerrit.cloudera.org:8080/21578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
Gerrit-Change-Number: 21578
Gerrit-PatchSet: 2
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jul 2024 13:41:14 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21578 )

Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write
......................................................................


Patch Set 9: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
Gerrit-Change-Number: 21578
Gerrit-PatchSet: 9
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jul 2024 09:01:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21578 )

Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write
......................................................................


Patch Set 5:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/16544/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/21578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
Gerrit-Change-Number: 21578
Gerrit-PatchSet: 5
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Jul 2024 12:33:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has uploaded a new patch set (#8). ( http://gerrit.cloudera.org:8080/21578 )

Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write
......................................................................

IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Impala can only modify an Iceberg table via 'merge-on-read'. The
'iceberg_always allow_merge_on_read_operations' backend flag makes it
possible to execute 'merge-on-read' operations (DELETE, UPDATE, MERGE)
even if the table property is 'copy-on-write'.

Testing:
 - custom cluster test
 - negative E2E test

Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
---
M be/src/common/global-flags.cc
M be/src/util/backend-gflag-util.cc
M common/thrift/BackendGflags.thrift
M fe/src/main/java/org/apache/impala/analysis/IcebergDeleteImpl.java
M fe/src/main/java/org/apache/impala/analysis/IcebergModifyImpl.java
M fe/src/main/java/org/apache/impala/analysis/IcebergUpdateImpl.java
M fe/src/main/java/org/apache/impala/service/BackendConfig.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
A tests/custom_cluster/test_iceberg_always_allow_merge_on_read.py
9 files changed, 115 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/21578/8
-- 
To view, visit http://gerrit.cloudera.org:8080/21578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
Gerrit-Change-Number: 21578
Gerrit-PatchSet: 8
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21578 )

Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write
......................................................................


Patch Set 8:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/16548/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/21578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
Gerrit-Change-Number: 21578
Gerrit-PatchSet: 8
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jul 2024 09:21:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/21578 )

Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write
......................................................................

IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Impala can only modify an Iceberg table via 'merge-on-read'. The
'iceberg_always allow_merge_on_read_operations' backend flag makes it
possible to execute 'merge-on-read' operations (DELETE, UPDATE, MERGE)
even if the table property is 'copy-on-write'.

Testing:
 - custom cluster test

Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
---
M be/src/common/global-flags.cc
M be/src/util/backend-gflag-util.cc
M common/thrift/BackendGflags.thrift
M fe/src/main/java/org/apache/impala/analysis/IcebergDeleteImpl.java
M fe/src/main/java/org/apache/impala/analysis/IcebergModifyImpl.java
M fe/src/main/java/org/apache/impala/analysis/IcebergUpdateImpl.java
M fe/src/main/java/org/apache/impala/service/BackendConfig.java
A tests/custom_cluster/test_iceberg_always_allow_merge_on_read.py
8 files changed, 112 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/21578/2
-- 
To view, visit http://gerrit.cloudera.org:8080/21578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
Gerrit-Change-Number: 21578
Gerrit-PatchSet: 2
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21578 )

Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write
......................................................................

IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Impala can only modify an Iceberg table via 'merge-on-read'. The
'iceberg_always allow_merge_on_read_operations' backend flag makes it
possible to execute 'merge-on-read' operations (DELETE, UPDATE, MERGE)
even if the table property is 'copy-on-write'.

Testing:
 - custom cluster test
 - negative E2E test

Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
Reviewed-on: http://gerrit.cloudera.org:8080/21578
Reviewed-by: Daniel Becker <da...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/common/global-flags.cc
M be/src/util/backend-gflag-util.cc
M common/thrift/BackendGflags.thrift
M fe/src/main/java/org/apache/impala/analysis/IcebergDeleteImpl.java
M fe/src/main/java/org/apache/impala/analysis/IcebergModifyImpl.java
M fe/src/main/java/org/apache/impala/analysis/IcebergUpdateImpl.java
M fe/src/main/java/org/apache/impala/service/BackendConfig.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
A tests/custom_cluster/test_iceberg_always_allow_merge_on_read.py
9 files changed, 115 insertions(+), 16 deletions(-)

Approvals:
  Daniel Becker: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/21578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
Gerrit-Change-Number: 21578
Gerrit-PatchSet: 10
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21578 )

Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21578/1/tests/custom_cluster/test_iceberg_enable_merge_on_read.py
File tests/custom_cluster/test_iceberg_enable_merge_on_read.py:

http://gerrit.cloudera.org:8080/#/c/21578/1/tests/custom_cluster/test_iceberg_enable_merge_on_read.py@31
PS1, Line 31: \
flake8: E502 the backslash is redundant between brackets


http://gerrit.cloudera.org:8080/#/c/21578/1/tests/custom_cluster/test_iceberg_enable_merge_on_read.py@32
PS1, Line 32: \
flake8: E502 the backslash is redundant between brackets



-- 
To view, visit http://gerrit.cloudera.org:8080/21578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
Gerrit-Change-Number: 21578
Gerrit-PatchSet: 1
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Jul 2024 14:25:15 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21578 )

Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write
......................................................................


Patch Set 4: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10805/


-- 
To view, visit http://gerrit.cloudera.org:8080/21578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
Gerrit-Change-Number: 21578
Gerrit-PatchSet: 4
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jul 2024 20:28:06 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/21578 )

Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write
......................................................................

IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Impala can only modify an Iceberg table via 'merge-on-read'. The
'iceberg_always allow_merge_on_read_operations' backend flag makes it
possible to execute 'merge-on-read' operations (DELETE, UPDATE, MERGE)
even if the table property is 'copy-on-write'.

Testing:
 - custom cluster test
 - negative E2E test

Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
---
M be/src/common/global-flags.cc
M be/src/util/backend-gflag-util.cc
M common/thrift/BackendGflags.thrift
M fe/src/main/java/org/apache/impala/analysis/IcebergDeleteImpl.java
M fe/src/main/java/org/apache/impala/analysis/IcebergModifyImpl.java
M fe/src/main/java/org/apache/impala/analysis/IcebergUpdateImpl.java
M fe/src/main/java/org/apache/impala/service/BackendConfig.java
M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test
A tests/custom_cluster/test_iceberg_always_allow_merge_on_read.py
9 files changed, 114 insertions(+), 15 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/21578/5
-- 
To view, visit http://gerrit.cloudera.org:8080/21578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
Gerrit-Change-Number: 21578
Gerrit-PatchSet: 5
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21578 )

Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
Gerrit-Change-Number: 21578
Gerrit-PatchSet: 5
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Jul 2024 12:13:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21578 )

Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/16536/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/21578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
Gerrit-Change-Number: 21578
Gerrit-PatchSet: 2
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jul 2024 12:26:29 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21578 )

Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/10804/


-- 
To view, visit http://gerrit.cloudera.org:8080/21578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
Gerrit-Change-Number: 21578
Gerrit-PatchSet: 2
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jul 2024 17:44:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21578 )

Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write
......................................................................


Patch Set 9:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10809/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/21578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
Gerrit-Change-Number: 21578
Gerrit-PatchSet: 9
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Mon, 22 Jul 2024 09:01:27 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21578 )

Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/16494/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/21578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
Gerrit-Change-Number: 21578
Gerrit-PatchSet: 1
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 11 Jul 2024 14:49:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21578 )

Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write
......................................................................


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21578/1/be/src/common/global-flags.cc
File be/src/common/global-flags.cc:

http://gerrit.cloudera.org:8080/#/c/21578/1/be/src/common/global-flags.cc@429
PS1, Line 429: allows DELETE, UPDATE and MERGE operations
We should include that these operations will be done with merge-on-read because Impala can't write with copy-on-write.


http://gerrit.cloudera.org:8080/#/c/21578/1/tests/custom_cluster/test_iceberg_enable_merge_on_read.py
File tests/custom_cluster/test_iceberg_enable_merge_on_read.py:

http://gerrit.cloudera.org:8080/#/c/21578/1/tests/custom_cluster/test_iceberg_enable_merge_on_read.py@54
PS1, Line 54: MERGE
We could add a TODO here with the Jira ticket for MERGE saying that once MERGE is available we should add a test for that too.



-- 
To view, visit http://gerrit.cloudera.org:8080/21578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
Gerrit-Change-Number: 21578
Gerrit-PatchSet: 1
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 17 Jul 2024 11:20:30 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21578 )

Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write
......................................................................


Patch Set 1:

(6 comments)

Thanks for working on this!

http://gerrit.cloudera.org:8080/#/c/21578/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21578/1//COMMIT_MSG@11
PS1, Line 11: )
nit: longer than 72 chars


http://gerrit.cloudera.org:8080/#/c/21578/1/be/src/common/global-flags.cc
File be/src/common/global-flags.cc:

http://gerrit.cloudera.org:8080/#/c/21578/1/be/src/common/global-flags.cc@428
PS1, Line 428: enable
Since merge-one-read is the default in Impala, I think a better name would be: "iceberg_always_allow_merge_on_read_operations".


http://gerrit.cloudera.org:8080/#/c/21578/1/fe/src/main/java/org/apache/impala/analysis/IcebergDeleteImpl.java
File fe/src/main/java/org/apache/impala/analysis/IcebergDeleteImpl.java:

http://gerrit.cloudera.org:8080/#/c/21578/1/fe/src/main/java/org/apache/impala/analysis/IcebergDeleteImpl.java@46
PS1, Line 46: deleteMode != null && !deleteMode.equals("merge-on-read")
Could be written as:

 "merge-on-read".equals(getModifyMode())

Or:

  Objects.equals(getModifyMode(), "merge-on-read")


http://gerrit.cloudera.org:8080/#/c/21578/1/fe/src/main/java/org/apache/impala/analysis/IcebergDeleteImpl.java@45
PS1, Line 45:     String deleteMode = getModifyMode();
            :     if (deleteMode != null && !deleteMode.equals("merge-on-read")
            :         && !isMergeOnReadEnabled()) {
            :       throw new AnalysisException(String.format("Unsupported delete mode: '%s' for " +
            :           "Iceberg table: %s", deleteMode, originalTargetTable_.getFullName()));
            :     }
This could be moved to super.analyze(). The error message would be "Unsupported write mode" instead of "Unsupported delete mode" / "Unsupported update mode", but I think it should be OK. Or see my comment below at getModifyMode().


http://gerrit.cloudera.org:8080/#/c/21578/1/fe/src/main/java/org/apache/impala/analysis/IcebergDeleteImpl.java@86
PS1, Line 86:   String getModifyMode() {
            :     return originalTargetTable_.getIcebergApiTable().properties()
            :         .get(TableProperties.DELETE_MODE);
            :   }
This method could just return "TableProperties.DELETE_MODE", then everything could be taken care by IcebergModifyImpl. The value of TableProperties.DELETE_MODE, namely "write.delete.mode", could be incorporated into the error message as well, e.g.:

 Unsupported write mode detected in table property 'write.delete.mode' of Iceberg table 'db.ice_t': 'copy-on-write'

Or stg like that.


http://gerrit.cloudera.org:8080/#/c/21578/1/fe/src/main/java/org/apache/impala/analysis/IcebergModifyImpl.java
File fe/src/main/java/org/apache/impala/analysis/IcebergModifyImpl.java:

http://gerrit.cloudera.org:8080/#/c/21578/1/fe/src/main/java/org/apache/impala/analysis/IcebergModifyImpl.java@120
PS1, Line 120: isMergeOnReadEnabled
This should be 'isMergeOnReadAlwaysAllowed()'



-- 
To view, visit http://gerrit.cloudera.org:8080/21578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
Gerrit-Change-Number: 21578
Gerrit-PatchSet: 1
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 16 Jul 2024 15:57:57 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21578 )

Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write
......................................................................


Patch Set 2: Code-Review+1

LGTM!


-- 
To view, visit http://gerrit.cloudera.org:8080/21578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
Gerrit-Change-Number: 21578
Gerrit-PatchSet: 2
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jul 2024 12:25:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21578 )

Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
Gerrit-Change-Number: 21578
Gerrit-PatchSet: 3
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jul 2024 15:14:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21578 )

Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/10804/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/21578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
Gerrit-Change-Number: 21578
Gerrit-PatchSet: 2
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Thu, 18 Jul 2024 12:43:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write

Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/21578 )

Change subject: IMPALA-12857: Add flag to enable merge-on-read even if tables are configured with copy-on-write
......................................................................


Patch Set 5: Code-Review-1

I found another failed test case, so this should not be merged as is.


-- 
To view, visit http://gerrit.cloudera.org:8080/21578
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3800043e135beeedfb655a238c0644aaa0ef11f4
Gerrit-Change-Number: 21578
Gerrit-PatchSet: 5
Gerrit-Owner: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 19 Jul 2024 12:21:59 +0000
Gerrit-HasComments: No