You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/05 15:14:00 UTC
[jira] [Commented] (FLINK-5253) Remove special treatment of
"dynamic properties"
[ https://issues.apache.org/jira/browse/FLINK-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16074914#comment-16074914 ]
ASF GitHub Bot commented on FLINK-5253:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3356#discussion_r125669802
--- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java ---
@@ -319,13 +306,7 @@ public AbstractYarnClusterDescriptor createDescriptor(String defaultApplicationN
yarnClusterDescriptor.setTaskManagerSlots(slots);
}
- String[] dynamicProperties = null;
- if (cmd.hasOption(DYNAMIC_PROPERTIES.getOpt())) {
- dynamicProperties = cmd.getOptionValues(DYNAMIC_PROPERTIES.getOpt());
- }
- String dynamicPropertiesEncoded = StringUtils.join(dynamicProperties, YARN_DYNAMIC_PROPERTIES_SEPARATOR);
-
- yarnClusterDescriptor.setDynamicPropertiesEncoded(dynamicPropertiesEncoded);
+ GlobalConfiguration.setDynamicProperties(retrieveDynamicProperties(cmd, DYNAMIC_PROPERTIES));
--- End diff --
Can we get around setting a static field in `GlobalConfiguration`? Why not parsing the dynamic properties and then passing them to the `ClusterDescriptor` at creation time. I guess it would also make sense to do the configuration loading outside of the `ClusterDescriptor`.
> Remove special treatment of "dynamic properties"
> ------------------------------------------------
>
> Key: FLINK-5253
> URL: https://issues.apache.org/jira/browse/FLINK-5253
> Project: Flink
> Issue Type: Sub-task
> Components: YARN
> Environment: {{flip-6}} feature branch
> Reporter: Stephan Ewen
> Labels: flip-6
>
> The YARN client accepts configuration keys as command line parameters.
> Currently these are send to the AppMaster and TaskManager as "dynamic properties", encoded in a special way via environment variables.
> The mechanism is quite fragile. We should simplify it:
> - The YARN client takes the local {{flink-conf.yaml}} as the base.
> - It overwrite config entries with command line properties when preparing the configuration to be shipped to YARN container processes (JM / TM)
> - No additional handling neccessary
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)