You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/08/19 16:46:12 UTC
[GitHub] [tvm] aasorokiin opened a new pull request #8797: VTA cmake change to include Verilator header for building tsim library
aasorokiin opened a new pull request #8797:
URL: https://github.com/apache/tvm/pull/8797
Proposed changes to VTA require verilator include directory to build module.cc.
Background:
VTA modification is proposed to support 64/128/256/512 bit AXI data bus. (vta pull request VTA Chisel Wide memory interface. #32) DPI support for those bit widths is implemented using svOpenArrayHandle from Verilator library from svdpi.h . The original implementation of module.cc uses 8/64 bit data type match and doesn't require special handling.
Resolves problem:
module.cc is compiled into tsim library by TVM.
Code contributions to this PR were made by the following individuals (in alphabetical order): @suvadeep89, @stevenmburns, @pasqoc, @adavare, @sjain12intel, @aasorokiin, and @zhenkuny.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] aasorokiin edited a comment on pull request #8797: VTA cmake change to include Verilator header for building tsim library
Posted by GitBox <gi...@apache.org>.
aasorokiin edited a comment on pull request #8797:
URL: https://github.com/apache/tvm/pull/8797#issuecomment-902371180
It should fix VTA PR
There is a more general problem with defines. That g++ argument define -D__STDC_FORMAT_MACROS is redefined in verilator includes and causes compilation error with -Werror
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] aasorokiin commented on a change in pull request #8797: VTA cmake change to include Verilator header for building tsim library
Posted by GitBox <gi...@apache.org>.
aasorokiin commented on a change in pull request #8797:
URL: https://github.com/apache/tvm/pull/8797#discussion_r694978691
##########
File path: cmake/modules/VTA.cmake
##########
@@ -73,15 +73,30 @@ elseif(PYTHON)
# Cycle accurate simulator driver build
if(USE_VTA_TSIM)
+ if(NOT DEFINED ENV{VERILATOR_INC_DIR})
Review comment:
In Jenkinsfile I see only BUILD:CPU runnig tests/scripts/task_python_vta_tsim.sh. Does it mean that all other targets could have build tsim disabled by config.cmake set(USE_VTA_TSIM OFF)? @vegaluisjose
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] aasorokiin commented on a change in pull request #8797: VTA cmake change to include Verilator header for building tsim library
Posted by GitBox <gi...@apache.org>.
aasorokiin commented on a change in pull request #8797:
URL: https://github.com/apache/tvm/pull/8797#discussion_r695357158
##########
File path: tests/scripts/task_config_build_cpu.sh
##########
@@ -34,7 +34,6 @@ echo set\(USE_NNPACK ON\) >> config.cmake
echo set\(NNPACK_PATH /NNPACK/build/\) >> config.cmake
echo set\(USE_ANTLR ON\) >> config.cmake
echo set\(CMAKE_CXX_COMPILER g++\) >> config.cmake
-echo set\(CMAKE_CXX_FLAGS -Werror\) >> config.cmake
Review comment:
Here is what worked for me. I removed verilated.cpp and verilated_dpi.cpp from cmake config src object list and included them in vta module.cc itself in 3rdparty/vta-hardware. Make compiles those sv functions right into module.cc object file where they are used. Somehow it doesn't flag warnings on compilation, but those needed functions got created. We will not see if it is the case till updated VTA is connected to this TVM. In this TVM those cpp files are not compiled and not required anywhere.
Disabling redefinition warning did not work as I was not able to find -W option for it. @stevenmburns
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] aasorokiin commented on a change in pull request #8797: VTA cmake change to include Verilator header for building tsim library
Posted by GitBox <gi...@apache.org>.
aasorokiin commented on a change in pull request #8797:
URL: https://github.com/apache/tvm/pull/8797#discussion_r694297979
##########
File path: cmake/modules/VTA.cmake
##########
@@ -73,15 +73,30 @@ elseif(PYTHON)
# Cycle accurate simulator driver build
if(USE_VTA_TSIM)
+ if(NOT DEFINED ENV{VERILATOR_INC_DIR})
Review comment:
1. Should arm, gpu, wasm configs build TSIM?
2. Is it acceptable to remove -Werror from tests/scripts/task_config_build_* files that build TSIM?
@vegaluisjose
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] aasorokiin commented on a change in pull request #8797: VTA cmake change to include Verilator header for building tsim library
Posted by GitBox <gi...@apache.org>.
aasorokiin commented on a change in pull request #8797:
URL: https://github.com/apache/tvm/pull/8797#discussion_r695261017
##########
File path: tests/scripts/task_config_build_cpu.sh
##########
@@ -34,7 +34,6 @@ echo set\(USE_NNPACK ON\) >> config.cmake
echo set\(NNPACK_PATH /NNPACK/build/\) >> config.cmake
echo set\(USE_ANTLR ON\) >> config.cmake
echo set\(CMAKE_CXX_COMPILER g++\) >> config.cmake
-echo set\(CMAKE_CXX_FLAGS -Werror\) >> config.cmake
Review comment:
-Werror is present in all other configurations which don't build with Verilator. Pulled back it will cause lib_tsim.so compilation failure due to warnings in Verilator source code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] aasorokiin commented on a change in pull request #8797: VTA cmake change to include Verilator header for building tsim library
Posted by GitBox <gi...@apache.org>.
aasorokiin commented on a change in pull request #8797:
URL: https://github.com/apache/tvm/pull/8797#discussion_r694380554
##########
File path: cmake/modules/VTA.cmake
##########
@@ -73,15 +73,30 @@ elseif(PYTHON)
# Cycle accurate simulator driver build
if(USE_VTA_TSIM)
+ if(NOT DEFINED ENV{VERILATOR_INC_DIR})
Review comment:
The latest tagged Verilator https://github.com/verilator/verilator/blob/v4.210/include/verilatedos.h#L279 still has it without check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vegaluisjose commented on pull request #8797: VTA cmake change to include Verilator header for building tsim library
Posted by GitBox <gi...@apache.org>.
vegaluisjose commented on pull request #8797:
URL: https://github.com/apache/tvm/pull/8797#issuecomment-902364049
If I understand correctly, this PR fixes the following [VTA PR](https://github.com/apache/tvm-vta/pull/32) right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] aasorokiin commented on pull request #8797: VTA cmake change to include Verilator header for building tsim library
Posted by GitBox <gi...@apache.org>.
aasorokiin commented on pull request #8797:
URL: https://github.com/apache/tvm/pull/8797#issuecomment-902151476
VTA-hardware build flow already requires VERILATOR_INC_DIR or it defines Verilator includes from those paths. Can it be accepted to have the same requirements for TVM tsim lib building?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vegaluisjose commented on a change in pull request #8797: VTA cmake change to include Verilator header for building tsim library
Posted by GitBox <gi...@apache.org>.
vegaluisjose commented on a change in pull request #8797:
URL: https://github.com/apache/tvm/pull/8797#discussion_r695258429
##########
File path: cmake/modules/VTA.cmake
##########
@@ -73,15 +73,28 @@ elseif(PYTHON)
# Cycle accurate simulator driver build
if(USE_VTA_TSIM)
+ if(DEFINED ENV{VERILATOR_INC_DIR})
+ set(VERILATOR_INC_DIR $ENV{VERILATOR_INC_DIR})
+ elseif (EXISTS /usr/local/share/verilator/include)
+ set(VERILATOR_INC_DIR /usr/local/share/verilator/include)
+ elseif (EXISTS /usr/share/verilator/include)
+ set(VERILATOR_INC_DIR /usr/share/verilator/include)
+ else()
+ message(STATUS "Verilator not found in /usr/local/share/verilator/include")
+ message(STATUS "Verilator not found in /usr/share/verilator/include")
+ message(FATAL_ERROR "Cannot find Verilator, VERILATOR_INC_DIR is not defined")
+ endif()
Review comment:
Sweet!
##########
File path: tests/scripts/task_config_build_cpu.sh
##########
@@ -34,7 +34,6 @@ echo set\(USE_NNPACK ON\) >> config.cmake
echo set\(NNPACK_PATH /NNPACK/build/\) >> config.cmake
echo set\(USE_ANTLR ON\) >> config.cmake
echo set\(CMAKE_CXX_COMPILER g++\) >> config.cmake
-echo set\(CMAKE_CXX_FLAGS -Werror\) >> config.cmake
Review comment:
Can we try pulling this back?..so others can see the issue in the CI log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vegaluisjose commented on a change in pull request #8797: VTA cmake change to include Verilator header for building tsim library
Posted by GitBox <gi...@apache.org>.
vegaluisjose commented on a change in pull request #8797:
URL: https://github.com/apache/tvm/pull/8797#discussion_r694316957
##########
File path: cmake/modules/VTA.cmake
##########
@@ -73,15 +73,30 @@ elseif(PYTHON)
# Cycle accurate simulator driver build
if(USE_VTA_TSIM)
+ if(NOT DEFINED ENV{VERILATOR_INC_DIR})
Review comment:
(1) I am not sure, CI has been in flux recently.
(2) I don't think it is possible but do you know if newer version of [Verilator](https://github.com/apache/tvm/blob/main/docker/install/ubuntu_install_verilator.sh#L24) might help clear those macros issues?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vegaluisjose commented on a change in pull request #8797: VTA cmake change to include Verilator header for building tsim library
Posted by GitBox <gi...@apache.org>.
vegaluisjose commented on a change in pull request #8797:
URL: https://github.com/apache/tvm/pull/8797#discussion_r693533655
##########
File path: cmake/modules/VTA.cmake
##########
@@ -73,15 +73,30 @@ elseif(PYTHON)
# Cycle accurate simulator driver build
if(USE_VTA_TSIM)
+ if(NOT DEFINED ENV{VERILATOR_INC_DIR})
Review comment:
This logic is not working out (CI is failing). I think it is generally better to have single if block rather than using a nested approach. For example:
```
if (NOT...)
elseif (EXISTS...)
elseif (EXISTS...)
else()
```
I double checked the docker image and the Verilator include dir is in `/usr/local/share/verilator/include`...here is some proof:
```
$ docker run --rm -it tvm_verilator bash
root@e7d413bdbd90:/# which verilator
/usr/local/bin/verilator
root@e7d413bdbd90:/# ls /usr/local/share/verilator/include/
gtkwave verilated_cov.cpp verilated_heavy.h verilated_syms.h verilated_vcd_sc.cpp
verilated.cpp verilated_cov.h verilated_imp.h verilated_threads.cpp verilated_vcd_sc.h
verilated.h verilated_cov_key.h verilated_intrinsics.h verilated_threads.h verilated_vpi.cpp
verilated.mk verilated_dpi.cpp verilated_save.cpp verilated_trace.h verilated_vpi.h
verilated.v verilated_dpi.h verilated_save.h verilated_trace_imp.cpp verilatedos.h
verilated_config.h verilated_fst_c.cpp verilated_sc.h verilated_vcd_c.cpp vltstd
verilated_config.h.in verilated_fst_c.h verilated_sym_props.h verilated_vcd_c.h
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] aasorokiin commented on pull request #8797: VTA cmake change to include Verilator header for building tsim library
Posted by GitBox <gi...@apache.org>.
aasorokiin commented on pull request #8797:
URL: https://github.com/apache/tvm/pull/8797#issuecomment-902371180
There is a more general problem with defines. That g++ argument define -D__STDC_FORMAT_MACROS is redefined in verilator includes and cause compilation error with -Werror
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vegaluisjose commented on a change in pull request #8797: VTA cmake change to include Verilator header for building tsim library
Posted by GitBox <gi...@apache.org>.
vegaluisjose commented on a change in pull request #8797:
URL: https://github.com/apache/tvm/pull/8797#discussion_r695006606
##########
File path: cmake/modules/VTA.cmake
##########
@@ -73,15 +73,30 @@ elseif(PYTHON)
# Cycle accurate simulator driver build
if(USE_VTA_TSIM)
+ if(NOT DEFINED ENV{VERILATOR_INC_DIR})
Review comment:
Could you rebase? so we can re-run CI again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vegaluisjose commented on a change in pull request #8797: VTA cmake change to include Verilator header for building tsim library
Posted by GitBox <gi...@apache.org>.
vegaluisjose commented on a change in pull request #8797:
URL: https://github.com/apache/tvm/pull/8797#discussion_r693548857
##########
File path: cmake/modules/VTA.cmake
##########
@@ -73,15 +73,30 @@ elseif(PYTHON)
# Cycle accurate simulator driver build
if(USE_VTA_TSIM)
+ if(NOT DEFINED ENV{VERILATOR_INC_DIR})
Review comment:
Fair enough. It will be still nice to rewrite that `if` logic for readability.
@tmoreau89 do you know what is the strategy (CI) for TSIM on gpu/arm images?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] aasorokiin edited a comment on pull request #8797: VTA cmake change to include Verilator header for building tsim library
Posted by GitBox <gi...@apache.org>.
aasorokiin edited a comment on pull request #8797:
URL: https://github.com/apache/tvm/pull/8797#issuecomment-902371180
It should fix VTA PR
There is a more general problem with defines. That g++ argument define -D__STDC_FORMAT_MACROS is redefined in verilator includes and cause compilation error with -Werror
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vegaluisjose commented on a change in pull request #8797: VTA cmake change to include Verilator header for building tsim library
Posted by GitBox <gi...@apache.org>.
vegaluisjose commented on a change in pull request #8797:
URL: https://github.com/apache/tvm/pull/8797#discussion_r695002531
##########
File path: cmake/modules/VTA.cmake
##########
@@ -73,15 +73,30 @@ elseif(PYTHON)
# Cycle accurate simulator driver build
if(USE_VTA_TSIM)
+ if(NOT DEFINED ENV{VERILATOR_INC_DIR})
Review comment:
yeah, that sounds right.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] stevenmburns commented on pull request #8797: VTA cmake change to include Verilator header for building tsim library
Posted by GitBox <gi...@apache.org>.
stevenmburns commented on pull request #8797:
URL: https://github.com/apache/tvm/pull/8797#issuecomment-905027565
@aasorokiin You can probably be more selective about which warnings to consider as errors.
Here is an example:
```
> cat a.cpp
int main() {
int a;
return 0;
}
```
With `-Werror` set, you get a compilation failure:
```
> g++ -Wall -Werror a.cpp
a.cpp: In function ‘int main()’:
a.cpp:2:8: error: unused variable ‘a’ [-Werror=unused-variable]
int a;
^
cc1plus: all warnings being treated as errors
```
But you can turn off that particular error:
```
> g++ -Wall -Werror -Wno-error=unused-variable a.cpp
a.cpp: In function ‘int main()’:
a.cpp:2:8: warning: unused variable ‘a’ [-Wunused-variable]
int a;
^
```
This compiles. Maybe you can add the particular Verilator warnings to a `-Wno-error` option to clean this up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] aasorokiin commented on a change in pull request #8797: VTA cmake change to include Verilator header for building tsim library
Posted by GitBox <gi...@apache.org>.
aasorokiin commented on a change in pull request #8797:
URL: https://github.com/apache/tvm/pull/8797#discussion_r693547334
##########
File path: cmake/modules/VTA.cmake
##########
@@ -73,15 +73,30 @@ elseif(PYTHON)
# Cycle accurate simulator driver build
if(USE_VTA_TSIM)
+ if(NOT DEFINED ENV{VERILATOR_INC_DIR})
Review comment:
sorry, I don't quite get it. I see several reasons CI build fails.
1. ci_arm. No "RUN bash /install/ubuntu_install_verilator.sh" in docker/Dockerfile.ci_arm. As a result "Verilator not found"
2. ci_i386. Verilator was found, but __STDC_FORMAT_MACROS is unconditionally redefined in Verilator source and causes compilation error with -Werror in tests/scripts/task_config_build_i386.sh
3. ci_gpu. TSIM is enabled for some reason. Verilator is not installed in docker file. "Verilator not found."
So Cmake script looks working, but Verilator is not present in all scripts that build TSIM. And when it is present, tsim lib cannot compile because of Verilator source quality and -Werror requirement.
@vegaluisjose
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tmoreau89 merged pull request #8797: VTA cmake change to include Verilator header for building tsim library
Posted by GitBox <gi...@apache.org>.
tmoreau89 merged pull request #8797:
URL: https://github.com/apache/tvm/pull/8797
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] vegaluisjose commented on a change in pull request #8797: VTA cmake change to include Verilator header for building tsim library
Posted by GitBox <gi...@apache.org>.
vegaluisjose commented on a change in pull request #8797:
URL: https://github.com/apache/tvm/pull/8797#discussion_r694316957
##########
File path: cmake/modules/VTA.cmake
##########
@@ -73,15 +73,30 @@ elseif(PYTHON)
# Cycle accurate simulator driver build
if(USE_VTA_TSIM)
+ if(NOT DEFINED ENV{VERILATOR_INC_DIR})
Review comment:
(1) I am not sure, CI has been in flux recently.
(2) I don't think it is possible but do you know if newer version of [Verilator](https://github.com/apache/tvm/blob/main/docker/install/ubuntu_install_verilator.sh#L24) might help?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] aasorokiin commented on a change in pull request #8797: VTA cmake change to include Verilator header for building tsim library
Posted by GitBox <gi...@apache.org>.
aasorokiin commented on a change in pull request #8797:
URL: https://github.com/apache/tvm/pull/8797#discussion_r693547334
##########
File path: cmake/modules/VTA.cmake
##########
@@ -73,15 +73,30 @@ elseif(PYTHON)
# Cycle accurate simulator driver build
if(USE_VTA_TSIM)
+ if(NOT DEFINED ENV{VERILATOR_INC_DIR})
Review comment:
sorry, I don't quite get it. I see several reasons CI build fails.
1. ci_arm. No "RUN bash /install/ubuntu_install_verilator.sh" in docker/Dockerfile.ci_arm. As a result "Verilator not found"
2. ci_i386. Verilator was found, but __STDC_FORMAT_MACROS is unconditionally redefined in Verilator source and causes compilation error with -Werror
3. ci_gpu. TSIM is enabled for some reason. Verilator is not installed in docker file. "Verilator not found."
So Cmake script looks working, but Verilator is not present in all scripts that build TSIM. And when it is present, tsim lib cannot compile because of Verilator source quality and -Werror requirement.
@vegaluisjose
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tmoreau89 commented on pull request #8797: VTA cmake change to include Verilator header for building tsim library
Posted by GitBox <gi...@apache.org>.
tmoreau89 commented on pull request #8797:
URL: https://github.com/apache/tvm/pull/8797#issuecomment-906598135
Thanks @vegaluisjose @aasorokiin and the rest of the contributing team, the PR has been merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org