You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2021/09/04 10:15:46 UTC
[GitHub] [netbeans] matthiasblaesing commented on pull request #3152: fixes reponse code check for http status code 301 moved permanently;
matthiasblaesing commented on pull request #3152:
URL: https://github.com/apache/netbeans/pull/3152#issuecomment-912947886
Setting up a host that returns a http Status 200 for a given URL should be trivial and thus it is unnessary to use a third party for this. The currently configured url for connection checking is:
https://github.com/apache/netbeans/blob/3b964b0079f7b4726fd447f89cb71b56899df953/platform/o.n.core/src/org/netbeans/core/ProxySettings.java#L65
which returns a valid 200:
```
matthias@enterprise:~$ curl -sSkv -o /dev/null https://netbeans.apache.org 2>&1 | grep "^<"
< HTTP/2 200
< server: Apache
< last-modified: Sun, 30 May 2021 17:02:24 GMT
< etag: "303c-5c38f12ab8493"
< access-control-allow-origin: *
< content-type: text/html
< via: 1.1 varnish, 1.1 varnish
< accept-ranges: bytes
< date: Sat, 04 Sep 2021 10:08:10 GMT
< age: 3730
< x-served-by: cache-hel6831-HEL, cache-muc13921-MUC
< x-cache: HIT, HIT
< x-cache-hits: 1, 1
< x-timer: S1630750091.887080,VS0,VE0
< vary: Accept-Encoding
< content-length: 12348
<
matthias@enterprise:
```
The URL change was issued about 5 months ago by: https://github.com/apache/netbeans/commit/026738caa88157117c9ac7828cc68cef7c23f5e1. For the usecase "Apache NetBeans *" I don't see a reason to change anything here.
Testing with master showed, that connection checking works and I had a look with wireshark and at least judging from the SNI header of the TLS handshake the right host is addressed. Is this a fix, that is not needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists