You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/05 22:07:14 UTC

[GitHub] [arrow] wesm commented on a change in pull request #1036: ARROW-1452: [C++] Restore DISALLOW_COPY_AND_ASSIGN usages removed in ARROW-1452 patch

wesm commented on a change in pull request #1036:
URL: https://github.com/apache/arrow/pull/1036#discussion_r762622077



##########
File path: cpp/src/arrow/util/macros.h
##########
@@ -22,7 +22,7 @@
 #ifndef ARROW_DISALLOW_COPY_AND_ASSIGN
 #define ARROW_DISALLOW_COPY_AND_ASSIGN(TypeName) \
   TypeName(const TypeName&) = delete;            \
-  TypeName& operator=(const TypeName&) = delete
+  void operator=(const TypeName&) = delete

Review comment:
       I don't remember why. Changing it back to a reference type would probably be a good idea, can you open a Jira issue?
   
   https://en.wikipedia.org/wiki/Assignment_operator_(C%2B%2B)#Return_value_of_overloaded_assignment_operator




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org