You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@kafka.apache.org by Neha Narkhede <ne...@gmail.com> on 2013/10/15 02:31:37 UTC

Review Request 14641: Patch for KAFKA-1086

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14641/
-----------------------------------------------------------

Review request for kafka.


Bugs: KAFKA-1086
    https://issues.apache.org/jira/browse/KAFKA-1086


Repository: kafka


Description
-------

Improved GetOffsetShell to query metadata automatically, add batch offset request for all partitions of a topic and improve usability


Diffs
-----

  core/src/main/scala/kafka/tools/GetOffsetShell.scala 2b9438ae3a4da2c7f97e05fb26bc179fe48f137d 

Diff: https://reviews.apache.org/r/14641/diff/


Testing
-------


Thanks,

Neha Narkhede

Re: Review Request 14641: Patch for KAFKA-1086

Posted by Guozhang Wang <gu...@linkedin.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14641/#review27005
-----------------------------------------------------------



core/src/main/scala/kafka/tools/GetOffsetShell.scala
<https://reviews.apache.org/r/14641/#comment52584>

    I thought mkString is used to transfer an iterable to String, not vice versa?


- Guozhang Wang


On Oct. 15, 2013, 12:31 a.m., Neha Narkhede wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14641/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2013, 12:31 a.m.)
> 
> 
> Review request for kafka.
> 
> 
> Bugs: KAFKA-1086
>     https://issues.apache.org/jira/browse/KAFKA-1086
> 
> 
> Repository: kafka
> 
> 
> Description
> -------
> 
> Improved GetOffsetShell to query metadata automatically, add batch offset request for all partitions of a topic and improve usability
> 
> 
> Diffs
> -----
> 
>   core/src/main/scala/kafka/tools/GetOffsetShell.scala 2b9438ae3a4da2c7f97e05fb26bc179fe48f137d 
> 
> Diff: https://reviews.apache.org/r/14641/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Neha Narkhede
> 
>