You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by xu...@apache.org on 2024/11/01 13:50:15 UTC
(opendal) branch main updated: chore: run object_store tests in CI (#5268)
This is an automated email from the ASF dual-hosted git repository.
xuanwo pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/opendal.git
The following commit(s) were added to refs/heads/main by this push:
new 8e142c8f8a chore: run object_store tests in CI (#5268)
8e142c8f8a is described below
commit 8e142c8f8ac0c7d85bc710871667fbf820501b96
Author: Jorge Hermo <jo...@gmail.com>
AuthorDate: Fri Nov 1 14:50:10 2024 +0100
chore: run object_store tests in CI (#5268)
---
.github/workflows/ci_integration_object_store.yml | 4 ++++
integrations/object_store/src/lib.rs | 15 +++++----------
integrations/object_store/src/store.rs | 15 +++++----------
3 files changed, 14 insertions(+), 20 deletions(-)
diff --git a/.github/workflows/ci_integration_object_store.yml b/.github/workflows/ci_integration_object_store.yml
index 824186aef1..bedd48aa3e 100644
--- a/.github/workflows/ci_integration_object_store.yml
+++ b/.github/workflows/ci_integration_object_store.yml
@@ -45,3 +45,7 @@ jobs:
- name: Cargo clippy
working-directory: integrations/object_store
run: cargo clippy --all-targets --all-features -- -D warnings
+
+ - name: Cargo test
+ working-directory: integrations/object_store
+ run: cargo test
diff --git a/integrations/object_store/src/lib.rs b/integrations/object_store/src/lib.rs
index 37b46d171b..2afe685eb8 100644
--- a/integrations/object_store/src/lib.rs
+++ b/integrations/object_store/src/lib.rs
@@ -31,16 +31,11 @@
//!
//! #[tokio::main]
//! async fn main() {
-//! let builder = S3::from_map(
-//! vec![
-//! ("access_key".to_string(), "my_access_key".to_string()),
-//! ("secret_key".to_string(), "my_secret_key".to_string()),
-//! ("endpoint".to_string(), "my_endpoint".to_string()),
-//! ("region".to_string(), "my_region".to_string()),
-//! ]
-//! .into_iter()
-//! .collect(),
-//! ).unwrap();
+//! let builder = S3::default()
+//! .access_key_id("my_access_key")
+//! .secret_access_key("my_secret_key")
+//! .endpoint("my_endpoint")
+//! .region("my_region");
//!
//! // Create a new operator
//! let operator = Operator::new(builder).unwrap().finish();
diff --git a/integrations/object_store/src/store.rs b/integrations/object_store/src/store.rs
index d7dc8193a1..1339f1bb78 100644
--- a/integrations/object_store/src/store.rs
+++ b/integrations/object_store/src/store.rs
@@ -62,16 +62,11 @@ use tokio::sync::{Mutex, Notify};
///
/// #[tokio::main]
/// async fn main() {
-/// let builder = S3::from_map(
-/// vec![
-/// ("access_key".to_string(), "my_access_key".to_string()),
-/// ("secret_key".to_string(), "my_secret_key".to_string()),
-/// ("endpoint".to_string(), "my_endpoint".to_string()),
-/// ("region".to_string(), "my_region".to_string()),
-/// ]
-/// .into_iter()
-/// .collect(),
-/// ).unwrap();
+/// let builder = S3::default()
+/// .access_key_id("my_access_key")
+/// .secret_access_key("my_secret_key")
+/// .endpoint("my_endpoint")
+/// .region("my_region");
///
/// // Create a new operator
/// let operator = Operator::new(builder).unwrap().finish();