[jira] [Work logged] (GOBBLIN-1792) Upgrade Mockito 1.* to 4.*

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-1792?focusedWorklogId=848456&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-848456 ]

ASF GitHub Bot logged work on GOBBLIN-1792:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 01/Mar/23 20:44
            Start Date: 01/Mar/23 20:44
    Worklog Time Spent: 10m 
      Work Description: Will-Lo commented on code in PR #3651:
URL: https://github.com/apache/gobblin/pull/3651#discussion_r1122276405


##########
gradle/scripts/globalDependencies.gradle:
##########
@@ -57,6 +57,7 @@ subprojects {
         }
       }
       all*.exclude group: 'org.apache.calcite', module: 'calcite-avatica' // replaced by org.apache.calcite.avatica:avatica-core
+      all*.exclude group: 'org.mockito', module: 'mockito-all'

Review Comment:
   Can we leave a comment why we need to make this exclusion?



##########
gobblin-aws/src/test/java/org/apache/gobblin/aws/GobblinAWSClusterLauncherTest.java:
##########
@@ -64,6 +44,19 @@
 import org.apache.gobblin.cluster.TestHelper;
 import org.apache.gobblin.cluster.TestShutdownMessageHandlerFactory;
 import org.apache.gobblin.testing.AssertWithBackoff;
+import org.apache.helix.HelixManager;
+import org.apache.helix.HelixManagerFactory;
+import org.apache.helix.InstanceType;
+import org.apache.helix.model.Message;
+import org.mockito.Mock;
+import org.mockito.Mockito;
+import org.mockito.MockitoAnnotations;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+import org.testng.Assert;
+import org.testng.annotations.AfterClass;
+import org.testng.annotations.BeforeClass;
+import org.testng.annotations.Test;

Review Comment:
   Can we follow the import order on the style guide?
   https://gobblin.apache.org/docs/developer-guide/CodingStyle/
   There's an intellij file you can set as the guide and intellij can autoformat the imports for you.
   On a side note I should look into trying to enforce this as part of checkstyle but that'll come later<sup>tm</sup>





Issue Time Tracking
-------------------

            Worklog Id:     (was: 848456)
    Remaining Estimate: 0h
            Time Spent: 10m

> Upgrade Mockito 1.* to 4.*
> --------------------------
>
>                 Key: GOBBLIN-1792
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1792
>             Project: Apache Gobblin
>          Issue Type: Improvement
>            Reporter: Matthew Ho
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Mockito version is ancient. Let's update it! And get rid of the need for powermockito



--
This message was sent by Atlassian Jira
(v8.20.10#820010)