You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Alok Lal <al...@hortonworks.com> on 2016/03/23 02:16:50 UTC
Review Request 45192: Audit shutdown hook to be registered with Hadoop
ShutdownHookManager instead of directly with Java Runtime
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45192/
-----------------------------------------------------------
Review request for ranger and Madhan Neethiraj.
Bugs: RANGER-891
https://issues.apache.org/jira/browse/RANGER-891
Repository: ranger
Description
-------
update assembly for solr plugin so it also includes the hadoop commons jar needed for this shutdownhook manager.
Diffs
-----
agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java cb998cd
src/main/assembly/plugin-solr.xml 31ebd6b
Diff: https://reviews.apache.org/r/45192/diff/
Testing
-------
- Manual testing of HDFS and HS2 plugin. Send kill -3 NN and HS2 while it was reciving traffic and generating audit messages to verify all stages of JVMShutdownHook processing happen as expected.
- Verified that assembly files of all plugins does contain hadoop-commons which contains the shutdownhook manager.
- Verified that new assembly of solr plug in packages hadoop-common under lib (it already did it for install/lib)
Thanks,
Alok Lal
Re: Review Request 45192: Audit shutdown hook to be registered with
Hadoop ShutdownHookManager instead of directly with Java Runtime
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45192/#review124941
-----------------------------------------------------------
Fix it, then Ship it!
Can you please verify that Solr plugin is able to process shutdown hook with addition of hadoop-common library? Just to make sure ShudownHookManager does not require any other library that is no already included?
agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java (line 454)
<https://reviews.apache.org/r/45192/#comment187648>
"30" ==> RANGER_AUDIT_SHUTDOWN_HOOK_PRIORITY
- Madhan Neethiraj
On March 23, 2016, 1:16 a.m., Alok Lal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45192/
> -----------------------------------------------------------
>
> (Updated March 23, 2016, 1:16 a.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-891
> https://issues.apache.org/jira/browse/RANGER-891
>
>
> Repository: ranger
>
>
> Description
> -------
>
> update assembly for solr plugin so it also includes the hadoop commons jar needed for this shutdownhook manager.
>
>
> Diffs
> -----
>
> agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java cb998cd
> src/main/assembly/plugin-solr.xml 31ebd6b
>
> Diff: https://reviews.apache.org/r/45192/diff/
>
>
> Testing
> -------
>
> - Manual testing of HDFS and HS2 plugin. Send kill -3 NN and HS2 while it was reciving traffic and generating audit messages to verify all stages of JVMShutdownHook processing happen as expected.
> - Verified that assembly files of all plugins does contain hadoop-commons which contains the shutdownhook manager.
> - Verified that new assembly of solr plug in packages hadoop-common under lib (it already did it for install/lib)
>
>
> Thanks,
>
> Alok Lal
>
>
Re: Review Request 45192: Audit shutdown hook to be registered with
Hadoop ShutdownHookManager instead of directly with Java Runtime
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45192/#review125385
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On March 25, 2016, 1:48 a.m., Alok Lal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45192/
> -----------------------------------------------------------
>
> (Updated March 25, 2016, 1:48 a.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-891
> https://issues.apache.org/jira/browse/RANGER-891
>
>
> Repository: ranger
>
>
> Description
> -------
>
> update assembly for solr plugin so it also includes the hadoop commons jar needed for this shutdownhook manager.
>
>
> Diffs
> -----
>
> agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java cb998cd
>
> Diff: https://reviews.apache.org/r/45192/diff/
>
>
> Testing
> -------
>
> - Manual testing of HDFS and HS2 plugin. Send kill -3 NN and HS2 while it was reciving traffic and generating audit messages to verify all stages of JVMShutdownHook processing happen as expected.
> - Verified that assembly files of all plugins does contain hadoop-commons which contains the shutdownhook manager.
> - Verified that new assembly of solr plug in packages hadoop-common under lib (it already did it for install/lib)
>
>
> Thanks,
>
> Alok Lal
>
>
Re: Review Request 45192: Audit shutdown hook to be registered with
Hadoop ShutdownHookManager instead of directly with Java Runtime
Posted by Alok Lal <al...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45192/
-----------------------------------------------------------
(Updated March 24, 2016, 6:48 p.m.)
Review request for ranger and Madhan Neethiraj.
Changes
-------
Addressed the review comments.
Bugs: RANGER-891
https://issues.apache.org/jira/browse/RANGER-891
Repository: ranger
Description
-------
update assembly for solr plugin so it also includes the hadoop commons jar needed for this shutdownhook manager.
Diffs (updated)
-----
agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java cb998cd
Diff: https://reviews.apache.org/r/45192/diff/
Testing
-------
- Manual testing of HDFS and HS2 plugin. Send kill -3 NN and HS2 while it was reciving traffic and generating audit messages to verify all stages of JVMShutdownHook processing happen as expected.
- Verified that assembly files of all plugins does contain hadoop-commons which contains the shutdownhook manager.
- Verified that new assembly of solr plug in packages hadoop-common under lib (it already did it for install/lib)
Thanks,
Alok Lal
Re: Review Request 45192: Audit shutdown hook to be registered with
Hadoop ShutdownHookManager instead of directly with Java Runtime
Posted by Alok Lal <al...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45192/
-----------------------------------------------------------
(Updated March 24, 2016, 6:47 p.m.)
Review request for ranger and Madhan Neethiraj.
Changes
-------
Ealrier patch wasn't rebased to current tip of ranger-0.5. This does **not** have rework comments. Those are in the next upload.
Bugs: RANGER-891
https://issues.apache.org/jira/browse/RANGER-891
Repository: ranger
Description
-------
update assembly for solr plugin so it also includes the hadoop commons jar needed for this shutdownhook manager.
Diffs (updated)
-----
agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditProviderFactory.java cb998cd
src/main/assembly/plugin-solr.xml 31ebd6b
Diff: https://reviews.apache.org/r/45192/diff/
Testing
-------
- Manual testing of HDFS and HS2 plugin. Send kill -3 NN and HS2 while it was reciving traffic and generating audit messages to verify all stages of JVMShutdownHook processing happen as expected.
- Verified that assembly files of all plugins does contain hadoop-commons which contains the shutdownhook manager.
- Verified that new assembly of solr plug in packages hadoop-common under lib (it already did it for install/lib)
Thanks,
Alok Lal