You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/04/07 15:19:59 UTC

[GitHub] [rocketmq] dugenkui03 opened a new pull request, #4132: [ISSUE #4130] Remove the exception which will never be thrown by method from method signature

dugenkui03 opened a new pull request, #4132:
URL: https://github.com/apache/rocketmq/pull/4132

   ## What is the purpose of the change
   #4130
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] tianliuliu commented on pull request #4132: [ISSUE #4130] Remove the exception which will never be thrown by method from method signature

Posted by GitBox <gi...@apache.org>.
tianliuliu commented on PR #4132:
URL: https://github.com/apache/rocketmq/pull/4132#issuecomment-1097503418

   Some businesses that use the old MQ client have caught these exceptions. When they are deleted in this new client, the business compile will fail, resulting in incompatible client versions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] francisoliverlee merged pull request #4132: [ISSUE #4130] Remove the exception which will never be thrown by method from method signature

Posted by GitBox <gi...@apache.org>.
francisoliverlee merged PR #4132:
URL: https://github.com/apache/rocketmq/pull/4132


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #4132: [ISSUE #4130] Remove the exception which will never be thrown by method from method signature

Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #4132:
URL: https://github.com/apache/rocketmq/pull/4132#issuecomment-1094170355

   
   [![Coverage Status](https://coveralls.io/builds/48146190/badge)](https://coveralls.io/builds/48146190)
   
   Coverage increased (+0.2%) to 51.958% when pulling **049abc24342d8bc10c1b4e842b948c777235e72d on dugenkui03:patch-012** into **8745d4c538d5c96e65a56f6278029c5765e7d922 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] dugenkui03 commented on pull request #4132: [ISSUE #4130] Remove the exception which will never be thrown by method from method signature

Posted by GitBox <gi...@apache.org>.
dugenkui03 commented on PR #4132:
URL: https://github.com/apache/rocketmq/pull/4132#issuecomment-1094171483

   > /home/travis/build/apache/rocketmq/srvutil/src/main/java/org/apache/rocketmq/srvutil/FileWatchService.java:26:8: error: Unused import - java.security.NoSuchAlgorithmException. Audit done.
   > 
   > Hi, CI not pass
   
   Thanks for your review, CI error is updated.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] codecov-commenter commented on pull request #4132: [ISSUE #4130] Remove the exception which will never be thrown by method from method signature

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #4132:
URL: https://github.com/apache/rocketmq/pull/4132#issuecomment-1094170178

   # [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4132?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#4132](https://codecov.io/gh/apache/rocketmq/pull/4132?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (049abc2) into [develop](https://codecov.io/gh/apache/rocketmq/commit/fd554ab12072225325c957ff6bdf492fc67821af?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fd554ab) will **decrease** coverage by `0.00%`.
   > The diff coverage is `0.00%`.
   
   ```diff
   @@              Coverage Diff              @@
   ##             develop    #4132      +/-   ##
   =============================================
   - Coverage      47.92%   47.91%   -0.01%     
   + Complexity      5002     4998       -4     
   =============================================
     Files            634      635       +1     
     Lines          42529    42496      -33     
     Branches        5573     5567       -6     
   =============================================
   - Hits           20381    20361      -20     
   + Misses         19647    19635      -12     
   + Partials        2501     2500       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/4132?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...g/apache/rocketmq/client/impl/MQClientAPIImpl.java](https://codecov.io/gh/apache/rocketmq/pull/4132/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9NUUNsaWVudEFQSUltcGwuamF2YQ==) | `13.98% <0.00%> (+0.11%)` | :arrow_up: |
   | [...ava/org/apache/rocketmq/test/util/VerifyUtils.java](https://codecov.io/gh/apache/rocketmq/pull/4132/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-dGVzdC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvdGVzdC91dGlsL1ZlcmlmeVV0aWxzLmphdmE=) | `46.26% <0.00%> (-2.99%)` | :arrow_down: |
   | [...ava/org/apache/rocketmq/filter/util/BitsArray.java](https://codecov.io/gh/apache/rocketmq/pull/4132/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZmlsdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9maWx0ZXIvdXRpbC9CaXRzQXJyYXkuamF2YQ==) | `59.82% <0.00%> (-2.57%)` | :arrow_down: |
   | [...va/org/apache/rocketmq/logging/inner/Appender.java](https://codecov.io/gh/apache/rocketmq/pull/4132/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9BcHBlbmRlci5qYXZh) | `34.83% <0.00%> (-2.25%)` | :arrow_down: |
   | [...ent/impl/consumer/DefaultLitePullConsumerImpl.java](https://codecov.io/gh/apache/rocketmq/pull/4132/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9EZWZhdWx0TGl0ZVB1bGxDb25zdW1lckltcGwuamF2YQ==) | `67.75% <0.00%> (-1.56%)` | :arrow_down: |
   | [...he/rocketmq/client/trace/AsyncTraceDispatcher.java](https://codecov.io/gh/apache/rocketmq/pull/4132/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvdHJhY2UvQXN5bmNUcmFjZURpc3BhdGNoZXIuamF2YQ==) | `78.21% <0.00%> (-1.49%)` | :arrow_down: |
   | [...mq/client/impl/consumer/RebalanceLitePullImpl.java](https://codecov.io/gh/apache/rocketmq/pull/4132/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9SZWJhbGFuY2VMaXRlUHVsbEltcGwuamF2YQ==) | `72.05% <0.00%> (-1.48%)` | :arrow_down: |
   | [...rg/apache/rocketmq/remoting/netty/NettyLogger.java](https://codecov.io/gh/apache/rocketmq/pull/4132/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3Rpbmcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3JlbW90aW5nL25ldHR5L05ldHR5TG9nZ2VyLmphdmE=) | `14.96% <0.00%> (-1.37%)` | :arrow_down: |
   | [...e/rocketmq/client/impl/consumer/RebalanceImpl.java](https://codecov.io/gh/apache/rocketmq/pull/4132/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9SZWJhbGFuY2VJbXBsLmphdmE=) | `43.75% <0.00%> (-1.18%)` | :arrow_down: |
   | [.../apache/rocketmq/logging/inner/LoggingBuilder.java](https://codecov.io/gh/apache/rocketmq/pull/4132/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bG9nZ2luZy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbG9nZ2luZy9pbm5lci9Mb2dnaW5nQnVpbGRlci5qYXZh) | `63.60% <0.00%> (-1.11%)` | :arrow_down: |
   | ... and [18 more](https://codecov.io/gh/apache/rocketmq/pull/4132/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/4132?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/4132?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fd554ab...049abc2](https://codecov.io/gh/apache/rocketmq/pull/4132?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #4132: [ISSUE #4130] Remove the exception which will never be thrown by method from method signature

Posted by GitBox <gi...@apache.org>.
coveralls commented on PR #4132:
URL: https://github.com/apache/rocketmq/pull/4132#issuecomment-1094170356

   
   [![Coverage Status](https://coveralls.io/builds/48146190/badge)](https://coveralls.io/builds/48146190)
   
   Coverage increased (+0.2%) to 51.958% when pulling **049abc24342d8bc10c1b4e842b948c777235e72d on dugenkui03:patch-012** into **8745d4c538d5c96e65a56f6278029c5765e7d922 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] dugenkui03 commented on pull request #4132: [ISSUE #4130] Remove the exception which will never be thrown by method from method signature

Posted by GitBox <gi...@apache.org>.
dugenkui03 commented on PR #4132:
URL: https://github.com/apache/rocketmq/pull/4132#issuecomment-1097517281

   > Some businesses that use the old MQ client have caught these exceptions. When they are deleted in this new client, the business compile will fail, resulting in incompatible client versions.
   
   Yes, you are right. I think it is nessary to correct the method signature as soon as possible to avoid more technical debt. This pr should be a breaking change.
   
   # Describe in Chinese
   你是对的。但是我认为仍然有必要修正这个错误以避免更多的技术债务，这对于相关方法算是 重大更新(beaking change)。
   
   在提交此 PR 的过程中也考虑到了尽可能合理的向前兼容，例如 1处调用 永远不会抛出 2异常`MQBrokerException`、但鉴于该类实现的接口方法定义抛出了`deletePlainAccessConfig`、此处没有去掉`MQBrokerException`。
   <img width="818" alt="image" src="https://user-images.githubusercontent.com/18216266/163094159-adb8174c-0ca1-4d8e-9c68-eeff40a7ee36.png">
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] tianliuliu commented on pull request #4132: [ISSUE #4130] Remove the exception which will never be thrown by method from method signature

Posted by GitBox <gi...@apache.org>.
tianliuliu commented on PR #4132:
URL: https://github.com/apache/rocketmq/pull/4132#issuecomment-1097650194

   > > Some businesses that use the old MQ client have caught these exceptions. When they are deleted in this new client, the business compile will fail, resulting in incompatible client versions.
   > 
   > Yes, you are right. I think it is nessary to correct the method signature as soon as possible to avoid more technical debt. This pr should be a breaking change.
   > 
   > # Describe in Chinese
   > 你是对的。但是我认为仍然有必要修正这个错误以避免更多的技术债务，这对于相关方法算是 重大更新(beaking change)。
   > 
   > 在提交此 PR 的过程中也考虑到了尽可能合理的向前兼容，例如 1处调用 永远不会抛出 2异常`MQBrokerException`、但鉴于该类实现的接口方法定义抛出了`deletePlainAccessConfig`、此处没有去掉`MQBrokerException`。 <img alt="image" width="818" src="https://user-images.githubusercontent.com/18216266/163094159-adb8174c-0ca1-4d8e-9c68-eeff40a7ee36.png">
   
   link @RongtongJin 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org