You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/08 03:15:20 UTC

[GitHub] [arrow-datafusion] xudong963 commented on a diff in pull request #4547: bump sqllogictest to 0.9.0

xudong963 commented on code in PR #4547:
URL: https://github.com/apache/arrow-datafusion/pull/4547#discussion_r1042883881


##########
datafusion/core/tests/sqllogictests/test_files/misc.slt:
##########
@@ -19,8 +19,8 @@
 
 # Show string normalization working
 # '' --> (empty)
-# '' --> NULL   (TODO: needs https://github.com/apache/arrow-rs/issues/3268)
+# '' --> NULL
 query II
 select 'foo', '', NULL
 ----
-foo (empty)
\ No newline at end of file
+foo (empty) NULL

Review Comment:
   @xxchan You are so quickly! 
   
   I noticed your new release and prepared to remove the issue about `NULL`. Then I found you done!
   
   Thank you



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org