You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by li...@apache.org on 2020/03/30 04:09:42 UTC

[incubator-dolphinscheduler] branch dev updated: some annotation optimizations (#2333)

This is an automated email from the ASF dual-hosted git repository.

lidongdai pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/incubator-dolphinscheduler.git


The following commit(s) were added to refs/heads/dev by this push:
     new f7e89e4  some annotation optimizations (#2333)
f7e89e4 is described below

commit f7e89e4561da0b76bf82a496c2649994664a051c
Author: songgg <11...@qq.com>
AuthorDate: Mon Mar 30 12:09:34 2020 +0800

    some annotation optimizations (#2333)
    
    Co-authored-by: songqh <so...@foxmail.com>
---
 .../org/apache/dolphinscheduler/api/service/ExecutorService.java  | 2 +-
 .../java/org/apache/dolphinscheduler/common/enums/ZKNodeType.java | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ExecutorService.java b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ExecutorService.java
index 86b507f..fe43f10 100644
--- a/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ExecutorService.java
+++ b/dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/ExecutorService.java
@@ -98,7 +98,7 @@ public class ExecutorService extends BaseService{
                                                    String receivers, String receiversCc, RunMode runMode,
                                                    Priority processInstancePriority, int workerGroupId, Integer timeout) throws ParseException {
         Map<String, Object> result = new HashMap<>(5);
-        // timeout is valid
+        // timeout is invalid
         if (timeout <= 0 || timeout > MAX_TASK_TIMEOUT) {
             putMsg(result,Status.TASK_TIMEOUT_PARAMS_ERROR);
             return result;
diff --git a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/ZKNodeType.java b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/ZKNodeType.java
index 8982c2a..b4b3c59 100644
--- a/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/ZKNodeType.java
+++ b/dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/ZKNodeType.java
@@ -22,10 +22,10 @@ package org.apache.dolphinscheduler.common.enums;
 public enum ZKNodeType {
 
     /**
-     * 0 do not send warning;
-     * 1 send if process success;
-     * 2 send if process failed;
-     * 3 send if process ending;
+     * 0 master node;
+     * 1 worker node;
+     * 2 dead_server node;
+     * 3 task_queue node;
      */
     MASTER, WORKER, DEAD_SERVER, TASK_QUEUE;
 }