You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/07/01 12:04:58 UTC

[GitHub] [incubator-nuttx] yamt opened a new pull request #4022: tcp_close: Fix a race with passive close

yamt opened a new pull request #4022:
URL: https://github.com/apache/incubator-nuttx/pull/4022


   ## Summary
   
   tcp_close disposes the connection immediately if it's called in
   TCP_LAST_ACK. If it happens, we will end up with responding the
   last ACK with a RST.
   
   This commit fixes it by making tcp_close wait for the completion
   of the passive close.
   
   extracted from https://github.com/apache/incubator-nuttx/pull/3991
   
   ## Impact
   
   tcp
   
   ## Testing
   
   tested on esp32 with the rest of https://github.com/apache/incubator-nuttx/pull/3991
   against macos and netbsd.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] yamt commented on pull request #4022: tcp_close: Fix a race with passive close

Posted by GitBox <gi...@apache.org>.
yamt commented on pull request #4022:
URL: https://github.com/apache/incubator-nuttx/pull/4022#issuecomment-872713652


   @masayuki2009 thank you for extensive testing


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 merged pull request #4022: tcp_close: Fix a race with passive close

Posted by GitBox <gi...@apache.org>.
masayuki2009 merged pull request #4022:
URL: https://github.com/apache/incubator-nuttx/pull/4022


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #4022: tcp_close: Fix a race with passive close

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #4022:
URL: https://github.com/apache/incubator-nuttx/pull/4022#issuecomment-872631362


   @yamt 
   
   Thanks for the fix!
   I confirmed the issue has been fixed for both TCP_WRITE_BUFFERS=y and n.
   However, let me try more complex tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx] masayuki2009 commented on pull request #4022: tcp_close: Fix a race with passive close

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #4022:
URL: https://github.com/apache/incubator-nuttx/pull/4022#issuecomment-872712485


   >However, let me try more complex tests.
   
   @yamt 
   There are no issues so far.
   Let me merge this PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org